Skip to content

Conversation

@heatherlarsen
Copy link
Contributor

@heatherlarsen heatherlarsen commented Nov 20, 2025

📌 Summary

If merged, this PR adds more details about sorting for table and advanced table columns. A consumer requested this via our general feedback form (results).

preview: table, advanced table

📸 Screenshots

before:
Screenshot 2025-11-20 at 9 25 47 AM

after:
Screenshot 2025-11-20 at 9 32 38 AM


👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

@heatherlarsen heatherlarsen requested review from a team as code owners November 20, 2025 17:26
@heatherlarsen heatherlarsen added the docs-website Content updates to the documentation website label Nov 20, 2025
@heatherlarsen heatherlarsen self-assigned this Nov 20, 2025
@vercel
Copy link

vercel bot commented Nov 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Nov 20, 2025 5:31pm
hds-website Ready Ready Preview Nov 20, 2025 5:31pm

Copy link
Contributor

@jorytindall jorytindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good addition, but I wonder if it's worth it to even include a line item that is broader, e.g., consumers can basically sort by any method they want using the custom sort callback, they just have to build it themselves. Designers aren't really going to know that this is supported unless they dig through the code docs, and it's even buried a bit in there.

I'm not sure exactly how you would say this, but maybe including it in the second bullet point:

  • In addition to standard sorting methods (like alphabetical or chronological), domain-specific sorting, such as by status severity, can also be useful. While custom sorting methods are supported, it is the responsibility of the consumer to determine the sorting logic.

@heatherlarsen
Copy link
Contributor Author

@jorytindall

While custom sorting methods are supported, it is the responsibility of the consumer to determine the sorting logic.

I've tried to avoid the term "supported" so it doesn't sound like the functionality is provided out of the box.

Also, aren't all sorting methods the consumer's responsibility to implement? If that is the case, I'm not seeing the value the additional content provides. Can you help me understand what's unclear or what you're hoping a designer would get from this new information?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-website Content updates to the documentation website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants