Website: Convert Form > TextArea demos to new format#3683
Website: Convert Form > TextArea demos to new format#3683shleewhite wants to merge 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| <F.CharacterCount @minLength={{100}} @minLength={{200}}/> | ||
| </Hds::Form::Textarea::Field> | ||
| ``` | ||
| [[code-snippets/textarea-complex-character-count]] |
There was a problem hiding this comment.
There's a difference in the number of required characters in the updated snippet. Is this as expected?
There was a problem hiding this comment.
oh interesting... not sure whats going on there. but the example has a minimum of 100 characters, so 78 is the correct number more that need to be added.
Going to leave it as is.
| <F.Error as |E|> | ||
| <E.Message>Length should be at least 12 characters</E.Message> | ||
| <E.Message>Can not contain HTML</E.Message> | ||
| <E.Message>B</E.Message> |
There was a problem hiding this comment.
Nit: This "B", which is in the new snippets too, looks weird/confusing to me in the rendered example. Would we maybe want to update or remove it?
There was a problem hiding this comment.
totally! I removed it.
KristinLBradley
left a comment
KristinLBradley
left a comment
There was a problem hiding this comment.
Looks good. Just added a couple minor questions/comments.
shleewhite
force-pushed
the
hds-5861/textarea-demos
branch
from
7a33ec7 to
0ec3be4
Compare
3 participants
📌 Summary
If merged, this PR would convert the Form > Textarea demos to the new format.
Current
Proposed
🔗 External links
Jira ticket: HDS-5861
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.