Website: Convert Form > TextInput demos to the new format#3684
Website: Convert Form > TextInput demos to the new format#3684shleewhite wants to merge 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| <F.CharacterCount @maxLength={{30}}/> | ||
| </Hds::Form::TextInput::Field> | ||
| ``` | ||
| [[code-snippets/text-input-character-count-max]] |
There was a problem hiding this comment.
For the updated code snippet, it no longer has the pre-filled cluster name text in the input. Does this matter? (In the following similar examples too)
There was a problem hiding this comment.
Ahh good callout, I missed a few of these. pushing up a change to fix.
| {{/if}} | ||
| </Hds::Form::TextInput::Field> | ||
| ``` | ||
| [[code-snippets/text-input-character-count-validation]] |
There was a problem hiding this comment.
Since the updated example no longer contains pre-filled text in the input, it doesn't display an error message regarding the length any more. Is this ok?
There was a problem hiding this comment.
yeah, its right that the error should be visible. fixed.
KristinLBradley
left a comment
KristinLBradley
left a comment
There was a problem hiding this comment.
Just added a few questions/comments regarding pre-filled text included in the original examples missing in the updated snippets.
shleewhite
force-pushed
the
hds-5860/text-input-demos
branch
from
f52ad81 to
87c72ac
Compare
3 participants
📌 Summary
If merged, this PR would convert the Form > TextInput demos to the new format.
Current
Proposed
🔗 External links
Jira ticket: HDS-5860
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.