[Project Solar / Phase 1 / Components] Tag carbonization#3685
[Project Solar / Phase 1 / Components] Tag carbonization#3685dchyun wants to merge 6 commits intoproject-solar/phase-1-main-feature-branchfrom
Tag carbonization#3685Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| .hds-tag__dismiss, | ||
| .hds-tag__text { | ||
| color: var(--token-color-foreground-primary); | ||
| color: var(--token-tag-foreground-color-default); |
There was a problem hiding this comment.
Looks like this style was there before (now gone in this PR) that was controlling the svg icon color:
.hds-tag__dismiss-icon, .hds-tag__text {
color: var(--token-color-foreground-primary);
}
There was a problem hiding this comment.
This has been fixed now. I added in some icon color tokens like there are in Figma. I had to separate the link primary and secondary colors for the icon from the plain text color. So I have three new variables
tag.icon.colortag.link.icon.color.primarytag.link.icon.color.secondary
jorytindall
left a comment
There was a problem hiding this comment.
I've matched up a couple of things in the Figma component (mainly the focus ring), I think this is looking solid, just left one note about the color of the icon in the dismiss button that is being inherited
5a0c760 to
e808c1b
Compare
90a171b to
f930a3f
Compare
f930a3f to
3222452
Compare
3222452 to
abc1f10
Compare
abc1f10 to
8015dca
Compare
showcase/app/components/page-carbonization/components/tag/index.gts
Outdated
Show resolved
Hide resolved
395ea90 to
6d0c7de
Compare
There was a problem hiding this comment.
Personally, I would leave the cutoff different (what is the issue)? I think we're overthinking this letter-spacing thing. For the end-user is not perceivable, it should be considered in the context of a wider, more complex UI.
7e08716 to
d7c6f15
Compare




📌 Summary
This PR carbonizes the
Tagcomponent and adds component tokens for it to the tokens library.Tag carbonization page
🛠️ Detailed description
Summary of changes:
🔗 External links
Jira ticket: HDS-6107
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.