Website: Convert Form > SuperSelect demos to the new format#3687
Website: Convert Form > SuperSelect demos to the new format#3687shleewhite wants to merge 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| If options are implemented as an array of strings and have the same name, they will be treated as the same, so selecting one will select others with the same name. To avoid this, implement your options using objects. (e.g. [{name: "name", label: "label"}, ...]) | ||
| !!! | ||
|
|
||
| **Nested data structure example:** |
There was a problem hiding this comment.
Would you maybe want to call out somewhere that the javascript in the updated code-snippets contains a nested data structure example?
| {{@option.size}} | ||
| </span> | ||
| ``` | ||
| [[code-snippets/example-selected-item-component execute=false]] |
There was a problem hiding this comment.
For this example, would we maybe want to add another code type since it doesn't really matter if it's GTS or HBS? (I know if you expand the code you can see the extra code around it in the GTS file though...)
There was a problem hiding this comment.
I'm kind of inclined to leave it as is... Just because it is what the consumers should do and it shows how you can correctly add arguments to the component. But I dont feel that strongly.
| </F.Options> | ||
| </Hds::Form::SuperSelect::Single::Field> | ||
| ``` | ||
| [[code-snippets/super-select-single-selected-item-component]] |
There was a problem hiding this comment.
For this one, in the updated code sippet,the pre-selected "Small" text no longer displays. Is that as expected?
There was a problem hiding this comment.
oh, Im still seeing it as preselected:
KristinLBradley
left a comment
KristinLBradley
left a comment
There was a problem hiding this comment.
Just added a few minor comments & questions.
shleewhite
force-pushed
the
hds-5858/super-select-demos
branch
from
62c5fd5 to
1e4da42
Compare
3 participants
📌 Summary
If merged, this PR would convert the Form > SuperSelect demos to thew new format.
Current
Proposed
🔗 External links
Jira ticket: HDS-5858
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.