Implement generic typing for AdvancedTable#3699
Draft
zamoore wants to merge 13 commits intozamoore/hds-5909/AdvancedTable-migrate_from_modelsfrom
Draft
Implement generic typing for AdvancedTable#3699zamoore wants to merge 13 commits intozamoore/hds-5909/AdvancedTable-migrate_from_modelsfrom
AdvancedTable#3699zamoore wants to merge 13 commits intozamoore/hds-5909/AdvancedTable-migrate_from_modelsfrom
Conversation
addressing PR feedback addressing pr feedback
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AdvancedTable
2ed714f to
0d0acce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR adds generic typing to
HdsAdvancedTableso thatB.datain the body block is inferred from the@modelelement type, giving consumers full type safety without@glint-expect-errorsuppressions.🛠️ Detailed description
HdsAdvancedTableSignatureandHdsAdvancedTablegeneric (T =Record<string, unknown>) so@model: T[]flows through todata: Tin the body block yield._asRowDatabridge method to connect the untyped sort-by helper's output back to T in the template.🔗 External links
Jira ticket: HDS-5543
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.