Skip to content

Implement generic typing for AdvancedTable#3699

Draft
zamoore wants to merge 13 commits intozamoore/hds-5909/AdvancedTable-migrate_from_modelsfrom
zamoore/hds-5543/AdvancedTable-generic-types
Draft

Implement generic typing for AdvancedTable#3699
zamoore wants to merge 13 commits intozamoore/hds-5909/AdvancedTable-migrate_from_modelsfrom
zamoore/hds-5543/AdvancedTable-generic-types

Conversation

@zamoore
Copy link
Contributor

@zamoore zamoore commented Mar 11, 2026

📌 Summary

If merged, this PR adds generic typing to HdsAdvancedTable so that B.data in the body block is inferred from the @model element type, giving consumers full type safety without @glint-expect-error suppressions.

🛠️ Detailed description

  • Made HdsAdvancedTableSignature and HdsAdvancedTable generic (T = Record<string, unknown>) so @model: T[] flows through to data: T in the body block yield.
  • Added _asRowData bridge method to connect the untyped sort-by helper's output back to T in the template.

🔗 External links

Jira ticket: HDS-5543


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel
Copy link

vercel bot commented Mar 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hds-showcase Ready Ready Preview Mar 11, 2026 6:43pm
hds-website Ready Ready Preview Mar 11, 2026 6:43pm

Request Review

@zamoore zamoore changed the title implement generic typing for AdvancedTable Implement generic typing for AdvancedTable Mar 11, 2026
@zamoore zamoore marked this pull request as ready for review March 11, 2026 18:45
@zamoore zamoore requested a review from a team as a code owner March 11, 2026 18:45
@zamoore zamoore marked this pull request as draft March 11, 2026 18:45
@zamoore zamoore force-pushed the zamoore/hds-5909/AdvancedTable-migrate_from_models branch 3 times, most recently from 2ed714f to 0d0acce Compare March 18, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants