fix: update syntax to V2 in GitHub Actions#580
Merged
ritikrajdev merged 4 commits intov2from Jan 14, 2026
Merged
Conversation
- Replace 'docker-compose' with 'docker compose' (V2 syntax) - Fixes 'command not found' error in GitHub Actions runners - Modern GitHub Actions runners have Docker Compose V2 pre-installed - Resolves SMB test workflow failures This change ensures the SMB integration tests can run successfully in the CI environment without requiring additional Docker Compose installation steps.
- Replace actions/upload-artifact@v3 with @v4 in both linux and windows jobs - Fixes deprecation warnings and potential workflow failures - v3 was deprecated on April 16, 2024 and will stop working - v4 is the current supported version for artifact uploads This resolves the automatic failure message: 'This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3'
- Update aws-actions/configure-aws-credentials from deprecated v1 to v4 - Improves security and compatibility with latest AWS authentication methods - Ensures reliable cloud resource authentication in CI workflows - Part of comprehensive GitHub Actions modernization effort
- Make artifact names unique by including Go version and directory matrix values - Replace '.' directory with 'root' in artifact names for better compatibility - Fixes 409 Conflict error: 'an artifact with this name already exists' - Each matrix combination now creates distinctly named artifacts Example artifact names: - linux-test-results-go1.19-root - linux-test-results-go1.20-s3 - windows-test-results-go1.21-gcs
CreatorHead
changed the title
ritikrajdev
reviewed
Jan 14, 2026
ritikrajdev
reviewed
Jan 14, 2026
ritikrajdev
approved these changes
Jan 14, 2026
ritikrajdev
left a comment
ritikrajdev
left a comment
There was a problem hiding this comment.
Overall LGTM, Feel free to resolve above mentioned questions and merge the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures the SMB integration tests can run successfully in the CI environment without requiring additional Docker Compose installation steps.
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.