Skip to content

tests: fix state version download test#1270

Merged
ctrombley merged 1 commit intomainfrom
ctrombley/fix-state-version-test
Jan 13, 2026
Merged

tests: fix state version download test#1270
ctrombley merged 1 commit intomainfrom
ctrombley/fix-state-version-test

Conversation

@ctrombley
Copy link
Copy Markdown
Collaborator

Description

This PR updates the state version download test to poll the resource and ensure the download URL is available before proceeding.

External links

@ctrombley ctrombley self-assigned this Jan 12, 2026
@ctrombley ctrombley requested a review from a team as a code owner January 12, 2026 20:48
brandonc
brandonc previously approved these changes Jan 12, 2026
Copy link
Copy Markdown
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@datadog-terraform-cloud-hashicorp
Copy link
Copy Markdown

datadog-terraform-cloud-hashicorp bot commented Jan 12, 2026

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

TestWorkspaces_AddTags/successfully_adds_tags_by_id_and_name from workspace_integration_test.go (Datadog)

	Error Trace:	/home/runner/work/go-tfe/go-tfe/workspace_integration_test.go:2950
	            				/home/runner/go/pkg/mod/github.com/!data!dog/dd-trace-go/v2@v2.5.0/internal/civisibility/integrations/gotesting/instrumentation_orchestrion.go:289
	            				/home/runner/go/pkg/mod/github.com/!data!dog/dd-trace-go/v2@v2.5.0/internal/civisibility/integrations/gotesting/instrumentation_orchestrion.go:293
	Error:      	Should NOT be empty, but was <nil>
	Test:       	TestWorkspaces_AddTags/successfully_adds_tags_by_id_and_name

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e8599eb | Docs | Was this helpful? Give us feedback!

@ctrombley ctrombley force-pushed the ctrombley/fix-state-version-test branch from b4333a8 to 47c24a5 Compare January 12, 2026 20:57
@ctrombley ctrombley force-pushed the ctrombley/fix-state-version-test branch from 47c24a5 to 8d18433 Compare January 12, 2026 21:02
@ctrombley ctrombley requested a review from brandonc January 12, 2026 21:02
brandonc
brandonc previously approved these changes Jan 12, 2026
@ctrombley ctrombley added the no-changelog-needed check changelog entry github workflow label Jan 12, 2026
@ctrombley ctrombley force-pushed the ctrombley/fix-state-version-test branch from 8d18433 to 5097e48 Compare January 12, 2026 21:06
@ctrombley ctrombley requested a review from brandonc January 12, 2026 21:09
@ctrombley ctrombley force-pushed the ctrombley/fix-state-version-test branch from 5097e48 to e8599eb Compare January 13, 2026 03:19
@ctrombley ctrombley merged commit b102694 into main Jan 13, 2026
24 of 26 checks passed
@ctrombley ctrombley deleted the ctrombley/fix-state-version-test branch January 13, 2026 19:36
@github-actions
Copy link
Copy Markdown

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-needed check changelog entry github workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants