Skip to content

tests: fix state version download test #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ctrombley merged 1 commit into from
Jan 13, 2026
Merged

tests: fix state version download test #1270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions helper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2386,6 +2386,20 @@ func createStateVersion(t *testing.T, client *Client, serial int64, w *Workspace
t.Fatal(err)
}

// Download URL may not be immediately available after creation
// Poll until download URL is ready
sv, err = retryPatientlyIf(
func() (any, error) {
return client.StateVersions.Read(ctx, sv.ID)
},
func(nsv *StateVersion) bool {
return nsv.DownloadURL == ""
},
)
if err != nil {
t.Fatal(err)
}

return sv, func() {
// There currently isn't a way to delete a state, so we
// can only cleanup by deleting the workspace.
Expand Down
34 changes: 26 additions & 8 deletions state_version_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,10 @@ func TestStateVersionsUpload(t *testing.T) {
require.NoError(t, err)

// Get a refreshed view of the configuration version.
sv, err = client.StateVersions.Read(ctx, sv.ID)
sv, err = retryPatientlyIf(
func() (any, error) { return client.StateVersions.Read(ctx, sv.ID) },
func(sv *StateVersion) bool { return sv.DownloadURL == "" },
)
require.NoError(t, err)

assert.NotEmpty(t, sv.SanitizedStateDownloadURL)
Expand Down Expand Up @@ -323,7 +326,10 @@ func TestStateVersionsCreate_RunDependent(t *testing.T) {
require.NoError(t, err)

// Get a refreshed view of the configuration version.
refreshed, err := client.StateVersions.Read(ctx, sv.ID)
refreshed, err := retryPatientlyIf(
func() (any, error) { return client.StateVersions.Read(ctx, sv.ID) },
func(sv *StateVersion) bool { return sv.DownloadURL == "" },
)
require.NoError(t, err)

_, err = client.Workspaces.Unlock(ctx, wTest.ID)
Expand All @@ -338,8 +344,9 @@ func TestStateVersionsCreate_RunDependent(t *testing.T) {
assert.NotEmpty(t, item.ID)
assert.Equal(t, int64(1), item.Serial)
assert.NotEmpty(t, item.CreatedAt)
assert.NotEmpty(t, item.DownloadURL)
}

assert.NotEmpty(t, refreshed.DownloadURL)
})

t.Run("with external state representation", func(t *testing.T) {
Expand All @@ -360,7 +367,10 @@ func TestStateVersionsCreate_RunDependent(t *testing.T) {
require.NoError(t, err)

// Get a refreshed view of the configuration version.
refreshed, err := client.StateVersions.Read(ctx, sv.ID)
refreshed, err := retryPatientlyIf(
func() (any, error) { return client.StateVersions.Read(ctx, sv.ID) },
func(sv *StateVersion) bool { return sv.DownloadURL == "" },
)
require.NoError(t, err)

_, err = client.Workspaces.Unlock(ctx, wTest.ID)
Expand All @@ -377,8 +387,9 @@ func TestStateVersionsCreate_RunDependent(t *testing.T) {
assert.NotEmpty(t, item.ID)
assert.Equal(t, int64(1), item.Serial)
assert.NotEmpty(t, item.CreatedAt)
assert.NotEmpty(t, item.DownloadURL)
}

assert.NotEmpty(t, refreshed.DownloadURL)
})

t.Run("with the force flag set", func(t *testing.T) {
Expand Down Expand Up @@ -406,7 +417,10 @@ func TestStateVersionsCreate_RunDependent(t *testing.T) {
require.NoError(t, err)

// Get a refreshed view of the configuration version.
refreshed, err := client.StateVersions.Read(ctx, sv.ID)
refreshed, err := retryPatientlyIf(
func() (any, error) { return client.StateVersions.Read(ctx, sv.ID) },
func(sv *StateVersion) bool { return sv.DownloadURL == "" },
)
require.NoError(t, err)

_, err = client.Workspaces.Unlock(ctx, wTest.ID)
Expand All @@ -421,8 +435,9 @@ func TestStateVersionsCreate_RunDependent(t *testing.T) {
assert.NotEmpty(t, item.ID)
assert.Equal(t, int64(2), item.Serial)
assert.NotEmpty(t, item.CreatedAt)
assert.NotEmpty(t, item.DownloadURL)
}

assert.NotEmpty(t, refreshed.DownloadURL)
})

t.Run("with a run to associate with", func(t *testing.T) {
Expand All @@ -442,7 +457,10 @@ func TestStateVersionsCreate_RunDependent(t *testing.T) {
require.NotEmpty(t, sv.Run)

// Get a refreshed view of the configuration version.
refreshed, err := client.StateVersions.Read(ctx, sv.ID)
refreshed, err := retryPatientlyIf(
func() (any, error) { return client.StateVersions.Read(ctx, sv.ID) },
func(sv *StateVersion) bool { return sv.DownloadURL == "" },
)
require.NoError(t, err)
require.NotEmpty(t, refreshed.Run)

Expand Down
Loading