chore: future-proof min and max function names#1014
Closed
sgap wants to merge 1 commit intohashicorp:mainfrom
Closed
chore: future-proof min and max function names#1014sgap wants to merge 1 commit intohashicorp:mainfrom
sgap wants to merge 1 commit intohashicorp:mainfrom
Conversation
ctrombley
force-pushed
the
future-proof-min-max-func-names
branch
from
63d9833 to
ce10af6
Compare
ctrombley
force-pushed
the
future-proof-min-max-func-names
branch
from
ce10af6 to
8822f23
Compare
uturunku1
approved these changes
Feb 26, 2025
Collaborator
|
Superseded by #1068. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Starting with go 1.21 the built-in function names min and max will conflict with variables of the same name.
This PR will update variable names from min to minimum and max to maximum.
This PR will future-proof code from the error that will be thrown by gocritic about the shadowing of predeclared identifiers.
Testing plan
External links
New min and max built-in functions
Output from tests