Skip to content

Add AgentPool to OAuthClientUpdateOptions#1075

Merged
ctrombley merged 2 commits intomainfrom
add_agent_pool_update
Apr 23, 2025
Merged

Add AgentPool to OAuthClientUpdateOptions#1075
ctrombley merged 2 commits intomainfrom
add_agent_pool_update

Conversation

@jpogran
Copy link
Copy Markdown
Contributor

@jpogran jpogran commented Mar 6, 2025 •
edited
Loading

Description

This change adds an AgentPool field to the OAuthClientUpdateOptions struct, which is used to associate a VCS Provider with an AgentPool for PrivateVCS support.

Testing plan

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" go test ./... -v -run TestFunctionsAffectedByChange

...

@jpogran jpogran self-assigned this Mar 6, 2025
@jpogran jpogran mentioned this pull request Mar 10, 2025
Closed
2 tasks
@jpogran jpogran force-pushed the add_agent_pool_update branch from 6698c7c to 062e800 Compare March 10, 2025 16:41
@datadog-terraform-cloud-hashicorp
Copy link
Copy Markdown

datadog-terraform-cloud-hashicorp bot commented Mar 10, 2025 •
edited
Loading

Datadog Report

Branch report: add_agent_pool_update
Commit report: d7cf7b1
Test service: hashicorp/go-tfe

✅ 0 Failed, 1440 Passed, 168 Skipped, 26m 8.06s Total Time
➡️ Test Sessions change in coverage: 1 no change

@jpogran jpogran marked this pull request as ready for review March 10, 2025 17:00
@jpogran jpogran requested a review from a team as a code owner March 10, 2025 17:00
@jpogran jpogran force-pushed the add_agent_pool_update branch from 062e800 to 4e5504d Compare April 2, 2025 18:17
@jpogran jpogran requested a review from ctrombley April 3, 2025 11:51
ctrombley
ctrombley reviewed Apr 3, 2025
View reviewed changes
CHANGELOG.md Outdated
Comment on lines +11 to +13
* Add AgentPool to OAuthClientUpdateOptions

Add `AgentPool` field to the OAuthClientUpdateOptions struct, which is used to associate a VCS Provider with an AgentPool for PrivateVCS support by @jpogran [#1075](https://github.com/hashicorp/go-tfe/pull/1075)
Copy link
Copy Markdown
Collaborator

@ctrombley ctrombley Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an additive change, should this be categorized under the Enhancements heading?

Copy link
Copy Markdown
Contributor Author

@jpogran jpogran Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Moved to enhancements

@roleesinhaHC roleesinhaHC requested a review from ctrombley April 17, 2025 17:29
@jpogran
Add AgentPool to OAuthClientUpdateOptions
9c61348 
This change adds an AgentPool field to the OAuthClientUpdateOptions struct, which is used to associate a VCS Provider with an AgentPool for PrivateVCS support.
@jpogran jpogran force-pushed the add_agent_pool_update branch from b4c3375 to 9c61348 Compare April 18, 2025 13:40
ctrombley
ctrombley previously approved these changes Apr 23, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ctrombley ctrombley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@roleesinhaHC roleesinhaHC requested a review from ctrombley April 23, 2025 21:23
ctrombley
ctrombley approved these changes Apr 23, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ctrombley ctrombley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ctrombley ctrombley merged commit 461e134 into main Apr 23, 2025
8 checks passed
@ctrombley ctrombley deleted the add_agent_pool_update branch April 23, 2025 22:43
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 23, 2025

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

@jpadrianoGo
Copy link
Copy Markdown
Contributor

jpadrianoGo commented Apr 26, 2025

Apologies, after syncing my fork branch with your latest change, I accidently updated the changelog to retain no changes.
There is an error https://github.com/hashicorp/go-tfe/actions/runs/14676569095/job/41193640884

My intention is to update/sync my fork through conflict resolution (after closing/opening multiple PRs)
PR: #1091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctrombley ctrombley ctrombley approved these changes

Assignees

@jpogran jpogran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpogran @jpadrianoGo @ctrombley @roleesinhaHC