TF-28651 deprecate endpoints

CHANGELOG.md

@@ -2,6 +2,14 @@
 
 # v1.91.1
 
+## Enhancements
+
+* Updates endpoint for deleting stack from `POST` to `DELETE` and removing `/delete` from endpoint by
+* Updates endpoint for force deleting stack from `POST` to `DELETE` and removing `/force-delete` from endpoint and adding `?force=true` by
+
+## Deprecations
+
+* The beta `StackDeployments`, `StackPlan`, `StackPlanOperation`, and `StackSource` resources have been removed, by @sahar-azizighannad  [#1205](https://github.com/hashicorp/go-tfe/pull/1205)
 ## Bug Fixes
 
 * Fixes timestamp attribute mapping for deployment runs to use correct API field names (`created-at`/`updated-at` instead of `started-at`/`completed-at`) by @shwetamurali [#1199](https://github.com/hashicorp/go-tfe/pull/1199)

stack.go

@@ -304,7 +304,7 @@ func (s stacks) Update(ctx context.Context, stackID string, options StackUpdateO
 
 // Delete deletes a stack.
 func (s stacks) Delete(ctx context.Context, stackID string) error {
-	req, err := s.client.NewRequest("POST", fmt.Sprintf("stacks/%s/delete", url.PathEscape(stackID)), nil)
+	req, err := s.client.NewRequest("DELETE", fmt.Sprintf("stacks/%s", url.PathEscape(stackID)), nil)
 	if err != nil {
 		return err
 	}
@@ -314,7 +314,7 @@ func (s stacks) Delete(ctx context.Context, stackID string) error {
 
 // ForceDelete deletes a stack that still has deployments.
 func (s stacks) ForceDelete(ctx context.Context, stackID string) error {
-	req, err := s.client.NewRequest("POST", fmt.Sprintf("stacks/%s/force-delete", url.PathEscape(stackID)), nil)
+	req, err := s.client.NewRequest("DELETE", fmt.Sprintf("stacks/%s?force=true", url.PathEscape(stackID)), nil)
 	if err != nil {
 		return err
 	}

stack_integration_test.go

@@ -340,37 +340,6 @@ func pollStackDeployments(t *testing.T, ctx context.Context, client *Client, sta
 	return
 }
 
-func pollStackDeploymentStatus(t *testing.T, ctx context.Context, client *Client, stackID, deploymentName, status string) {
-	// pollStackDeployments will poll the given stack until it has deployments or the deadline is reached.
-	ctx, cancel := context.WithDeadline(ctx, time.Now().Add(5*time.Minute))
-	defer cancel()
-
-	deadline, _ := ctx.Deadline()
-	t.Logf("Polling stack %q for deployments with deadline of %s", stackID, deadline)
-
-	ticker := time.NewTicker(2 * time.Second)
-	defer ticker.Stop()
-
-	for finished := false; !finished; {
-		t.Log("...")
-		select {
-		case <-ctx.Done():
-			t.Fatalf("Stack deployment %s/%s did not have status %q at deadline", stackID, deploymentName, status)
-		case <-ticker.C:
-			var err error
-			deployment, err := client.StackDeployments.Read(ctx, stackID, deploymentName)
-			if err != nil {
-				t.Fatalf("Failed to read stack deployment %s/%s: %s", stackID, deploymentName, err)
-			}
-
-			t.Logf("Stack deployment %s/%s had status %q", stackID, deploymentName, deployment.Status)
-			if deployment.Status == status {
-				finished = true
-			}
-		}
-	}
-}
-
 func pollStackConfigurationStatus(t *testing.T, ctx context.Context, client *Client, stackConfigID, status string) (stackConfig *StackConfiguration) {
 	// pollStackDeployments will poll the given stack until it has deployments or the deadline is reached.
 	ctx, cancel := context.WithDeadline(ctx, time.Now().Add(5*time.Minute))
@@ -440,9 +409,5 @@ func TestStackConverged(t *testing.T) {
 	require.ElementsMatch(t, deployments, stack.DeploymentNames)
 	require.NotNil(t, stack.LatestStackConfiguration)
 
-	for _, deployment := range deployments {
-		pollStackDeploymentStatus(t, ctx, client, stack.ID, deployment, "paused")
-	}
-
 	pollStackConfigurationStatus(t, ctx, client, stack.LatestStackConfiguration.ID, "converged")
 }