Skip to content

TF-33573 Adding policy set project exclusion.#1290

Closed
subhro-acharjee-1 wants to merge 5 commits intomainfrom
subhro/tf-33573-adding-policy-set-project-exclusion-support
Closed

TF-33573 Adding policy set project exclusion.#1290
subhro-acharjee-1 wants to merge 5 commits intomainfrom
subhro/tf-33573-adding-policy-set-project-exclusion-support

Conversation

@subhro-acharjee-1
Copy link

@subhro-acharjee-1 subhro-acharjee-1 commented Mar 9, 2026

Description

This PR adds the fuctionality to go-tfe to add and remove project policy set exclusions.

Testing plan

  • Setup local atlas
  • Run integration tests for this feature.
  • Integration should pass.
  • CI test should pass.

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" go test ./... -v -run TestFunctionsAffectedByChange

...
Screenshot 2026-03-12 at 12 34 23 PM

Rollback Plan

Changes to Security Controls

@hashicorp-cla-app
Copy link

hashicorp-cla-app bot commented Mar 9, 2026

CLA assistant check
All committers have signed the CLA.

@datadog-terraform-cloud-hashicorp
Copy link

datadog-terraform-cloud-hashicorp bot commented Mar 9, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 2 New flaky tests detected

TestWorkspacesCreate from workspace_integration_test.go (Datadog) (Fix with Cursor)
failed test
TestWorkspacesCreate/with_valid_options from workspace_integration_test.go (Datadog) (Fix with Cursor)

	Error Trace:	/home/runner/work/go-tfe/go-tfe/workspace_integration_test.go:779
	            				/home/runner/go/pkg/mod/github.com/!data!dog/dd-trace-go/v2@v2.6.0/internal/civisibility/integrations/gotesting/instrumentation_orchestrion.go:289
	            				/home/runner/go/pkg/mod/github.com/!data!dog/dd-trace-go/v2@v2.6.0/internal/civisibility/integrations/gotesting/instrumentation_orchestrion.go:293
	Error:      	Not equal: 
	            	expected: "tag1"
	            	actual  : "tag2"
	            	
	            	Diff:
	            	--- Expected
...

🧪 4 Tests failed

TestPolicySetAddProjectExclusions from policy_set_integration_test.go (Datadog) (Fix with Cursor)
failed test
TestPolicySetAddProjectExclusions/with_project_exclusions_provided from policy_set_integration_test.go (Datadog) (Fix with Cursor)

	Error Trace:	/home/runner/work/go-tfe/go-tfe/policy_set_integration_test.go:1289
	            				/home/runner/go/pkg/mod/github.com/!data!dog/dd-trace-go/v2@v2.6.0/internal/civisibility/integrations/gotesting/instrumentation_orchestrion.go:289
	            				/home/runner/go/pkg/mod/github.com/!data!dog/dd-trace-go/v2@v2.6.0/internal/civisibility/integrations/gotesting/instrumentation_orchestrion.go:293
	Error:      	Received unexpected error:
	            	resource not found
	Test:       	TestPolicySetAddProjectExclusions/with_project_exclusions_provided

TestPolicySetRemoveProjectExclusions from policy_set_integration_test.go (Datadog) (Fix with Cursor)
failed test
TestPolicySetRemoveProjectExclusions/with_project_exclusions_provided from policy_set_integration_test.go (Datadog) (Fix with Cursor)

	Error Trace:	/home/runner/work/go-tfe/go-tfe/policy_set_integration_test.go:1374
	            				/home/runner/go/pkg/mod/github.com/!data!dog/dd-trace-go/v2@v2.6.0/internal/civisibility/integrations/gotesting/instrumentation_orchestrion.go:289
	            				/home/runner/go/pkg/mod/github.com/!data!dog/dd-trace-go/v2@v2.6.0/internal/civisibility/integrations/gotesting/instrumentation_orchestrion.go:293
	Error:      	Received unexpected error:
	            	resource not found
	Test:       	TestPolicySetRemoveProjectExclusions/with_project_exclusions_provided

View all
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 92aff13 | Docs | Was this helpful? Give us feedback!

@mayank-sisodiya
Copy link

@subhro-acharjee-1 can you CI failing tests.

@subhro-acharjee-1
Copy link
Author

subhro-acharjee-1 commented Mar 12, 2026

@subhro-acharjee-1 can you CI failing tests.

This PR is dependent on https://github.com/hashicorp/atlas/pull/27313 until and unless this is merged to main the ci will fail.

@subhro-acharjee-1 subhro-acharjee-1 marked this pull request as ready for review March 16, 2026 05:22
@subhro-acharjee-1 subhro-acharjee-1 requested a review from a team as a code owner March 16, 2026 05:22
@subhro-acharjee-1 subhro-acharjee-1 changed the title TF-33573 adding policy set project exclusion. Adding policy set project exclusion. Mar 16, 2026
@subhro-acharjee-1 subhro-acharjee-1 changed the title Adding policy set project exclusion. TF-33573 Adding policy set project exclusion. Mar 16, 2026
@subhro-acharjee-1 subhro-acharjee-1 marked this pull request as draft March 16, 2026 05:29
@subhro-acharjee-1 subhro-acharjee-1 marked this pull request as ready for review March 16, 2026 11:02
@subhro-acharjee-1
Copy link
Author

Issue with the jira ticket, hence new PR with same changes #1292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants