filter warm-pool activities from status check in aws-asg target #1151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-project-automation
bot
moved this to Needs Triage
in Nomad - Community Issues Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least partly related to #885.
For specific information about the issues this PR fixes read: #885 (comment)
I am not very happy about having to filter on the activity description since this may be bound to change on AWS side whenever they want. However, we don't have any activityType field we can use and the only way we can differentiate activities is on the description right now. I might've also missed some descriptions that I haven't seen with my curent ASG-setup and from my searches I haven't found a list of possible combinations in the AWS docs.
Therefore I've only targeted the activity descriptions I've seen from my side that are related to launching/terminating instances in/from warm-pools. This way we only ignore warm-pool events, preventing other unknown activities from being affected by these changes. If the description would change for some reason the worst thing that can happen is that we wait for these activities again, so I suppose this could be acceptable.
In some cases some people would want to wait for these warm-pool events as well perhaps, so maybe it should be a configurable option?