Add a log statement showing the count returned by each autoscaler check.#1235
Add a log statement showing the count returned by each autoscaler check.#1235nathanmonteleone wants to merge 5 commits intohashicorp:mainfrom
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
1 similar comment
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
tgross
left a comment
There was a problem hiding this comment.
Thanks for the PR @nathanmonteleone!
I know it's a bit of a pain but can you please sign the CLA? Because you git history is dirty with a merge from main you've got commits from dependabot in here and that might confuse the CLA bot. You might want to rebase to clean that up as well.
| } else { | ||
| ch.log.Debug("check returned count", "strategy", ch.check.Strategy.Name, "check", ch.check.Name, "count", a.Count, "reason", a.Reason) |
There was a problem hiding this comment.
Style nitpick: we don't need to guard this in the else because all code paths in the if err != nil return.
| } else { | |
| ch.log.Debug("check returned count", "strategy", ch.check.Strategy.Name, "check", ch.check.Name, "count", a.Count, "reason", a.Reason) | |
| } | |
| ch.log.Debug("check returned count", "strategy", ch.check.Strategy.Name, "check", ch.check.Name, "count", a.Count, "reason", a.Reason) |
When troubleshooting more complex autoscaler policies, it can be useful to know what target count/reason each check is returning. That information was not available in the log previously. This changeset adds it as a Debug-level log.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
no.