fix: Output template rendering fails with --parser-v1 flag#875
Draft
TIMMAREDDYDEEKSHITHA-ship-it wants to merge 2 commits intomainfrom
Draft
fix: Output template rendering fails with --parser-v1 flag#875TIMMAREDDYDEEKSHITHA-ship-it wants to merge 2 commits intomainfrom
TIMMAREDDYDEEKSHITHA-ship-it wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #525
Problem
Output template rendering fails when using --parser-v1 flag with error: "nil pointer evaluating parser.PackContextable.job_name"
Solution
Added parser version check to use correct template context:
V1 parser: ConvertVariablesToMapInterface()
V2 parser: ToPackTemplateContext()
Changes
Modified: internal/pkg/renderer/renderer.go (added version check)
Added: internal/pkg/renderer/renderer_output_test.go (5 tests)
Testing
Template Rendering with V1 Parser
Job Deployment success
Reminders
CHANGELOG.mdentryChanges to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.