Skip to content

test(source): Consul KV integration tests#901

Merged
DeekshithaTimmareddy merged 4 commits into
feature/external-variable-sourcesfrom
feature/subtask2b-consul-tests
Jun 23, 2026
Merged

test(source): Consul KV integration tests#901
DeekshithaTimmareddy merged 4 commits into
feature/external-variable-sourcesfrom
feature/subtask2b-consul-tests

Conversation

@DeekshithaTimmareddy

@DeekshithaTimmareddy DeekshithaTimmareddy commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Description

Stacked on #898.

As discussed, Added integration tests for ConsulSource.Fetch. Also, CI now installs consul alongside nomad so the binary is on $PATH.

Reminders

  • Add CHANGELOG.md entry
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

@DeekshithaTimmareddy DeekshithaTimmareddy force-pushed the feature/subtask2b-consul-tests branch from ab8dbde to b47cb82 Compare June 19, 2026 18:20
@DeekshithaTimmareddy DeekshithaTimmareddy marked this pull request as ready for review June 19, 2026 18:34
@DeekshithaTimmareddy DeekshithaTimmareddy requested review from a team as code owners June 19, 2026 18:34

@tgross tgross left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is targeting the wrong branch. LLM-generated PR description. Tests don't pass.

@DeekshithaTimmareddy DeekshithaTimmareddy changed the base branch from main to feature/external-variable-sources June 22, 2026 16:25
@DeekshithaTimmareddy DeekshithaTimmareddy changed the title Feature/subtask2b consul tests test(source): Consul KV integration tests Jun 23, 2026
@DeekshithaTimmareddy

Copy link
Copy Markdown
Collaborator Author

PR is targeting the wrong branch. LLM-generated PR description. Tests don't pass.

The target is changed to feature/external-variable-sources. Also description i rewrote manually and when i tested these tests pass!

@tgross tgross left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DeekshithaTimmareddy DeekshithaTimmareddy merged commit 7d0ebcd into feature/external-variable-sources Jun 23, 2026
17 checks passed
@DeekshithaTimmareddy DeekshithaTimmareddy deleted the feature/subtask2b-consul-tests branch June 23, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants