[NO MERGE] Test HDS 4.18.0 release #25579
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristinLBradley
commented
Apr 1, 2025
ui/.tool-versions
Outdated
There was a problem hiding this comment.
I had to add this locally. Maybe it's confusing the tests in the CI though. I'll try removing
Removing file added for testing locally
KristinLBradley
force-pushed
the
kristin/hds-4.18.0-release-test
branch
from
9542b26 to
924091f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[NO MERGE] Testing HDS release
Issue: An update which removed extra bottom spacing from the
PageHeadercomponent is affecting some page layouts negatively. (Content below thePageHeaderis closer to it and in some cases touching it as there is not enough in-between spacing.)PR with change: hashicorp/design-system#2581
Action needed:
The PageHeader bottom spacing/margin will have to be replaced within Nomad as part of moving to HDS 4.18.0