Skip to content

Backport of Add NodeMaxAllocations to client configuration into release/1.10.x #25925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #25785 to be assessed for backporting due to the inclusion of the label backport/1.10.x.

The below text is copied from the body of the original PR.


Description

This PR introduces the concept of maximum allocations to the client via the client configuration file. This includes updates to the nomad node status command to add an Alloc Count column to the Allocated Resources section of the single node view. If node_max_alloc is defined it will be included as the denominator, otherwise we'll just report the count as a whole number.

Testing & Reproduction steps

The below screenshots were generated by running a single agent dev cluster and passing it the minimal configuration in command/agent/test-resources/client_with_max_allocs.hcl.

Single node status output when client.node_max_allocs is not set

allocs_not_set

Single node status output when client.node_max_allocs is set

allocs_set

Links

Github Issue #12783

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

Overview of commits

@tehut tehut merged commit 683e60d into release/1.10.x May 27, 2025
32 checks passed
@tehut tehut deleted the backport/f-max-allocations/nmd-617/eagerly-neat-malamute branch May 27, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants