Skip to content

Conversation

@jrasell
Copy link
Member

@jrasell jrasell commented Nov 3, 2025

There are enterprise tests do not include an OS build restriction but pull in code that is limited to Linux. This meant the test could not be run on non-linux and caused IDE errors. Along with fixing that error, the change consolidates two task runner test files which were both limited to Linux but used different build tagging mechanisms.

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

There are enterprise tests do not include an OS build restriction
but pull in code that is limited to Linux. This meant the test
could not be run on non-linux and caused IDE errors. Along with
fixing that error, the change consolidates two task runner test
files which were both limited to Linux but used different build
tagging mechanisms.
@jrasell jrasell self-assigned this Nov 3, 2025
@jrasell jrasell added backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent backport/1.10.x backport to 1.10.x release line labels Nov 3, 2025
@jrasell jrasell marked this pull request as ready for review November 3, 2025 12:28
@jrasell jrasell requested review from a team as code owners November 3, 2025 12:28
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrasell jrasell merged commit 6235838 into main Nov 4, 2025
47 checks passed
@jrasell jrasell deleted the b-test-taskrunner-darwin-compilation branch November 4, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent backport/1.10.x backport to 1.10.x release line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants