Skip to content

Conversation

@mismithhisler
Copy link
Member

@mismithhisler mismithhisler commented Nov 4, 2025

Description

These changes refactor some scheduler code to respect the disconnect.replace field which was currently being ignored and update some logic/method names for code readability.

Testing & Reproduction steps

Links

Fixes internal Jira NMD-1063
Fixes GH-27028

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

These changes refactor some scheduler code to respect the
disconnect.replace field which was currently being ignored and update
some logic/method names for code readability.
// ReplaceOnDisconnect determines if an alloc can be replaced
// when Disconnected.
func (a *Allocation) PreventReplaceOnDisconnect() bool {
func (a *Allocation) ReplaceOnDisconnect() bool {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to use positive function naming, which avoids double negatives.

@jrasell jrasell added this to the 1.11.x milestone Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

disconnect.replace behavior is different from docs

2 participants