OIDC check for issuer in auth response #27168
Draft
+145
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for RFC9207 (OAuth 2.0 Authorization Server Issuer Identification), by checking the OIDC authorization complete callback URL for the
issparameter, according to the OIDC provider's server metadata (authorization_response_iss_parameter_supported). If the provider requires the parameter and it is missing or does not match the provider's issuer url, the login request will fail.Failure using the cli
Failure in the UI returns a generic error
Testing & Reproduction steps
I was able to test this using Keycloak, following the Nomad SSO tutorial but stopping before enabling PCKE.
Keycloak supports this RFC by default, and will return the
issparameter in the callback, unless a specific Keycloak Client has adjusted the setting to omit it. Even in that case, the server metadata will still report that theissparameter is required, and the requests will fail if it isn't supplied.Requests will also fail if the
issvalue doesn't match the Issuer/OIDCDiscoveryURLthat was used to create the auth method in Nomad.Links
https://datatracker.ietf.org/doc/html/rfc9207
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.