qemu: add emulator allowlist to driver config and add emulator validadation #27182
+193
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
requested changes
Dec 2, 2025
Member
tgross
left a comment
tgross
left a comment
There was a problem hiding this comment.
There are some failing tests which I think cover the case where the user hasn't provided an explicit emulator argument
This change removed the fingerprint emulator config parameter and instead fingerprints all available emulators or those defined in the allowlist, and adds them to the drivers attribute, allowing placement contraints if nodes have different emulators installed.
mismithhisler
commented
Dec 2, 2025
mismithhisler
commented
Dec 2, 2025
gulducat
reviewed
Dec 2, 2025
Member
gulducat
left a comment
gulducat
left a comment
There was a problem hiding this comment.
lookin pretty good! nice to see qemu getting some love.
couple comments for ya
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes add the ability for nomad operators to specify a qemu emulator allowlist for fingerprinting and tasks. If no allowlist is specified, the driver fingerprints all available emulators. Additionally, the emulators are added to a new node attribute
driver.qemu.emulatorswhich enables using contraints to VM's on nodes with specific emulators, as this functionality is not yet built into the scheduler.Removed the
fingerprint_emulatorconfig, which was added in #27128.Testing & Reproduction steps
Links
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.