Skip to content

drivers: include volume within mount config#27710

Merged
chrisroberts merged 1 commit intomainfrom
f-driver-mount-name
May 5, 2026
Merged

drivers: include volume within mount config#27710
chrisroberts merged 1 commit intomainfrom
f-driver-mount-name

Conversation

@chrisroberts
Copy link
Copy Markdown
Member

@chrisroberts chrisroberts commented Mar 19, 2026

Description

Add an optional RequestName attribute to the mount config. If the mount config entry originated from a volume, the request name of the volume from the job spec will be included within the entry.

This modification is useful for drivers that may want to provide special handling of volumes. Including the volume name (if applicable) allows plugin configuration to reference the volumes and associate them to the correct mount configuration entries.

Testing & Reproduction steps

Links

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad product documentation, which is stored in the
    web-unified-docs repo. Refer to the web-unified-docs contributor guide for docs guidelines.
    Please also consider whether the change requires notes within the upgrade
    guide
    . If you would like help with the docs, tag the nomad-docs team in this PR.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Comment thread client/allocrunner/taskrunner/volume_hook.go Outdated
tgross
tgross previously approved these changes Mar 19, 2026
Copy link
Copy Markdown
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I suspect down the road we're going to want to stick more metadata about the volume we have on this struct, like the volume ID or source ID (from CSI), etc. We'll probably want to have some subset that we put on the request object itself as you've done here and then have a map of misc labels or whatever. But that's for future work!

Add an optional `RequestName` attribute to the mount config. If the mount
config entry originated from a volume, the request name of the volume used
within the jobspec will be included within the entry.
Copy link
Copy Markdown
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisroberts chrisroberts merged commit 1823e67 into main May 5, 2026
53 of 54 checks passed
@chrisroberts chrisroberts deleted the f-driver-mount-name branch May 5, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/ent/1.10.x+ent backport to 1.10.x+ent release line backport/ent/1.11.x+ent backport to 1.11.x+ent release line backport/2.0.x backport to 2.0.x release line theme/driver

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants