drivers: include volume within mount config#27710
Merged
chrisroberts merged 1 commit intomainfrom May 5, 2026
Merged
Conversation
tgross
reviewed
Mar 19, 2026
dfecf2e to
be952cb
Compare
be952cb to
34277fa
Compare
34277fa to
3aef7e2
Compare
3aef7e2 to
3ca9f3d
Compare
tgross
previously approved these changes
Mar 19, 2026
Member
tgross
left a comment
There was a problem hiding this comment.
LGTM!
I suspect down the road we're going to want to stick more metadata about the volume we have on this struct, like the volume ID or source ID (from CSI), etc. We'll probably want to have some subset that we put on the request object itself as you've done here and then have a map of misc labels or whatever. But that's for future work!
Add an optional `RequestName` attribute to the mount config. If the mount config entry originated from a volume, the request name of the volume used within the jobspec will be included within the entry.
3ca9f3d to
d32960b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an optional
RequestNameattribute to the mount config. If the mount config entry originated from a volume, the request name of the volume from the job spec will be included within the entry.This modification is useful for drivers that may want to provide special handling of volumes. Including the volume name (if applicable) allows plugin configuration to reference the volumes and associate them to the correct mount configuration entries.
Testing & Reproduction steps
Links
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.