deps: migrate docker/docker to moby/moby/client and moby/moby/api#27870
Open
pkazmierczak wants to merge 25 commits intomainfrom
Open
deps: migrate docker/docker to moby/moby/client and moby/moby/api#27870pkazmierczak wants to merge 25 commits intomainfrom
docker/docker to moby/moby/client and moby/moby/api#27870pkazmierczak wants to merge 25 commits intomainfrom
Conversation
pkazmierczak
force-pushed
the
f-migrate-docker-docker-to-moby-moby
branch
from
05dae15 to
2f4842f
Compare
pkazmierczak
added
theme/driver/docker
dependencies
tgross
reviewed
Apr 23, 2026
Comment on lines
+1
to
+2
| // Copyright IBM Corp. 2015, 2025 | ||
| // SPDX-License-Identifier: MPL-2.0 |
Member
There was a problem hiding this comment.
Oof, this has been vendored from https://github.com/moby/moby/blob/v28.5.2/libnetwork/resolvconf/resolvconf.go, right? I'm like 99% sure this should indicate that it's been vendored from there and we should retain the upstream copyright notice, rather than adding IBMs.
Member
There was a problem hiding this comment.
See https://github.com/hashicorp/nomad/blob/main/client/lib/nsutil/ns_linux.go for an example of how to do this.
Contributor
Author
There was a problem hiding this comment.
I actually haven't copied it, but in all honesty I'd rather have? So I'm gonna do the ns_linux thing instead.
…hicorp/nomad into f-migrate-docker-docker-to-moby-moby
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since v29, docker doesn’t publish its Go packages under github.com/docker/docker anymore. See: Release v29.0.0 · moby/moby
Go packages are now split into
moby/moby/apiandmoby/moby/client, which this changeset migrates to.note to reviewers: 99% of this huge PR is just adapting to the new APIs (which are frankly much better). The only tricky part is that we used to rely on two internal-to-docker libraries: resolvconf and registry. I vendored resolvconf code under
lib/resolvconf. registry package we only used for one or two methods and those were easy to replicate inline (see drivers/docker/utils.go).Internal ref: https://hashicorp.atlassian.net/browse/NMD-1404