Skip to content

Backport of bug fix: paused deployments failing progress deadline into release/2.0.x#27888

Open
hc-github-team-nomad-core wants to merge 1 commit intorelease/2.0.xfrom
backport/b-paused-deployment-timeout/nmd-1080/initially-ideal-lemming
Open

Backport of bug fix: paused deployments failing progress deadline into release/2.0.x#27888
hc-github-team-nomad-core wants to merge 1 commit intorelease/2.0.xfrom
backport/b-paused-deployment-timeout/nmd-1080/initially-ideal-lemming

Conversation

@hc-github-team-nomad-core
Copy link
Copy Markdown
Contributor

Backport

This PR is auto-generated from #27804 to be assessed for backporting due to the inclusion of the label backport/2.0.x.

The below text is copied from the body of the original PR.


Bug:
Support informed us of customers running into counterintuitive behavior where deployments were failing their progress deadline while paused.

Fix:

The changes below are intended make sure deployments don't fail as soon as they're un-paused

  • Updated the deploymentwatcher.getDeploymentStatusUpdate function to set an UpdatedAt time if the new deployment status is "paused" or "running" (might make sense to only reset on running instead of both)
  • Update the state store's updateDeploymentStatusImpl function to overwrite the deployment's ProgressDeadline with the UpdatedAt time + ProgressDeadline duration if neither u.UpdatedAt nor u.ProgressDeadline are 0.

Testing & Reproduction steps

  • Added an additional test case to deployments_watcher_test.go to assert:
    - that a paused deployment past its progress deadline will not fail
    - that the deployment's progress deadline == UpdatedAt + ProgressDeadline

Links

ref: https://hashicorp.atlassian.net/browse/NMD-1080?atlOrigin=eyJpIjoiMDI5YTFlZjZiMGM2NGQ4MWIwMDU1NjBhZDFjNzFiNjciLCJwIjoiaiJ9

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad product documentation, which is stored in the
    web-unified-docs repo. Refer to the web-unified-docs contributor guide for docs guidelines.
    Please also consider whether the change requires notes within the upgrade
    guide
    . If you would like help with the docs, tag the nomad-docs team in this PR.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.


Overview of commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants