Skip to content

Backport of deps: update go-plugin into release/2.0.x#27893

Merged
tgross merged 1 commit intorelease/2.0.xfrom
backport/deps-go-plugin/indirectly-noted-cricket
May 1, 2026
Merged

Backport of deps: update go-plugin into release/2.0.x#27893
tgross merged 1 commit intorelease/2.0.xfrom
backport/deps-go-plugin/indirectly-noted-cricket

Conversation

@hc-github-team-nomad-core
Copy link
Copy Markdown
Contributor

Backport

This PR is auto-generated from #27885 to be assessed for backporting due to the inclusion of the label backport/2.0.x.

The below text is copied from the body of the original PR.


When Nomad clients built on Go >=1.23 are restarted, the go-plugin client starts leaking a pidfd file handle 1/sec when polling for the plugin server. Long-term we should look at this polling behavior in more detail in the library because the pidfd may let us track the plugin status without polling. But in the meantime the leaking pidfd has been fixed upstream and we should pull that in.

Ref: hashicorp/go-plugin#378
Fixes: #27847

Testing and Reproduction Steps

Run any job and then restart the client agent. (Note this requires running not-in--dev mode.) Using this little script:

#!/usr/bin/env bash

while :
do
    ls /proc/$1/fd/ | wc -l
    sleep 1
done

We see that before the patch, the number of open file handles increases after restarting Nomad. After the patch, it does not.

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation n/a

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.


Overview of commits

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/deps-go-plugin/indirectly-noted-cricket branch from 3b40b54 to 4bff596 Compare May 1, 2026 19:55
@hc-github-team-nomad-core hc-github-team-nomad-core requested review from a team as code owners May 1, 2026 19:55
@tgross tgross merged commit 5d6969d into release/2.0.x May 1, 2026
32 of 33 checks passed
@tgross tgross deleted the backport/deps-go-plugin/indirectly-noted-cricket branch May 1, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants