cli: display job deadline if present#27913
Open
pkazmierczak wants to merge 4 commits intof-timeouts-for-batch-jobsfrom
Open
cli: display job deadline if present#27913pkazmierczak wants to merge 4 commits intof-timeouts-for-batch-jobsfrom
pkazmierczak wants to merge 4 commits intof-timeouts-for-batch-jobsfrom
Conversation
pkazmierczak
force-pushed
the
f-timeouts-for-batch-jobs
branch
from
e34dbc9 to
d3798f1
Compare
pkazmierczak
force-pushed
the
f-timeouts-for-batch-jobs-cli
branch
from
80e2c32 to
41ed075
Compare
Before: ``` $ nomad alloc status -verbose 8a24f147-9055-a2cb-8ede-b852466f35a1 ID = 8a24f147-9055-a2cb-8ede-b852466f35a1 ... Created = 2026-05-07T12:10:30-07:00 Modified = 2026-05-07T12:10:40-07:00 Max Run Deadline = 2026-05-07T19:10:40Z ``` After: ``` $ nomad alloc status -verbose 1d02ae9b-636e-ec2e-33ec-a0d1083aa6e9 ID = 1d02ae9b-636e-ec2e-33ec-a0d1083aa6e9 ... Created = 2026-05-07T12:23:41-07:00 Modified = 2026-05-07T12:23:42-07:00 Max Run Deadline = 2026-05-07T22:23:41-07:00 ```
schmichael
reviewed
May 7, 2026
| return time.Time{}, false | ||
| } | ||
|
|
||
| return latest.Local(), true |
Member
There was a problem hiding this comment.
I pushed this because I noticed the timezone wasn't localized in verbose output (like it is for created and modified timestamps). From the commit message:
display max run duration in local tz
Before:
```
$ nomad alloc status -verbose 8a24f147-9055-a2cb-8ede-b852466f35a1
ID = 8a24f147-9055-a2cb-8ede-b852466f35a1
...
Created = 2026-05-07T12:10:30-07:00
Modified = 2026-05-07T12:10:40-07:00
Max Run Deadline = 2026-05-07T19:10:40Z
```
After:
```
$ nomad alloc status -verbose 1d02ae9b-636e-ec2e-33ec-a0d1083aa6e9
ID = 1d02ae9b-636e-ec2e-33ec-a0d1083aa6e9
...
Created = 2026-05-07T12:23:41-07:00
Modified = 2026-05-07T12:23:42-07:00
Max Run Deadline = 2026-05-07T22:23:41-07:00
```
schmichael
approved these changes
May 7, 2026
Member
schmichael
left a comment
schmichael
left a comment
There was a problem hiding this comment.
LGTM! I pushed a tiny localization fix I noticed when playing with it locally. Hopefully didn't break the tests. 😬
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset adds displaying the deadline (if present) to all CLI commands
that display information about jobs or allocations.
See #27803 for context.