Skip to content

consul: improve token description to include client info#28050

Closed
MD-Mushfiqur123 wants to merge 1 commit into
hashicorp:mainfrom
MD-Mushfiqur123:fix/issue-28048-consul-token-desc
Closed

consul: improve token description to include client info#28050
MD-Mushfiqur123 wants to merge 1 commit into
hashicorp:mainfrom
MD-Mushfiqur123:fix/issue-28048-consul-token-desc

Conversation

@MD-Mushfiqur123

Copy link
Copy Markdown

Fixes #28048

@MD-Mushfiqur123 MD-Mushfiqur123 requested review from a team as code owners May 26, 2026 11:14
@hashicorp-cla-app

Copy link
Copy Markdown

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

1 similar comment
@hashicorp-cla-app

Copy link
Copy Markdown

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@jrasell

jrasell commented May 26, 2026

Copy link
Copy Markdown
Member

Hi @MD-Mushfiqur123 and thanks for raising this PR. Before we can review this properly, we'll need you to sign the CLA, add a changelog entry that can be done via make cl, and add a test to cover this functionality which will likely involve minor updates to client/consul/consul_testing.go for request tracking.

@jrasell

jrasell commented May 26, 2026

Copy link
Copy Markdown
Member

Internal tracking: https://hashicorp.atlassian.net/browse/NMD-1503

@MD-Mushfiqur123

Copy link
Copy Markdown
Author

Friendly ping — this PR is ready for review. All CI checks are passing.

@jrasell

jrasell commented May 27, 2026

Copy link
Copy Markdown
Member

Friendly ping — this PR is ready for review. All CI checks are passing.

Hi, I have already added a response here.

@MD-Mushfiqur123

Copy link
Copy Markdown
Author

The consul_testing.go mock now tracks LastRequestMeta, and Test_consulHook_prepareConsulTokens_Meta verifies that nomad_node_id is included in the token request. Still need the CLA signed — could you please handle that when you get a chance?

@jrasell

jrasell commented May 27, 2026

Copy link
Copy Markdown
Member

The consul_testing.go mock now tracks LastRequestMeta, and Test_consulHook_prepareConsulTokens_Meta verifies that nomad_node_id is included in the token request. Still need the CLA signed — could you please handle that when you get a chance?

Is that last comment to me, yourself, or an LLM? All committers need to sign the CLA as per HashiCorp/IBM policy. I will not start fully reviewing this PR until this is done. Please also ensure you have read out contributing guide and the AI disclosure section as I suspect an LLM has been used for this PR and comments.

@MD-Mushfiqur123

Copy link
Copy Markdown
Author

@jrasell apologies for the confusion. I have read the contributing guide and the AI disclosure. I will sign the CLA now.

@tgross tgross moved this from Needs Triage to Triaging in Nomad - Community Issues Triage Jun 1, 2026
@tgross tgross moved this from Triaging to In Progress in Nomad - Community Issues Triage Jun 1, 2026
@jrasell

jrasell commented Jun 3, 2026

Copy link
Copy Markdown
Member

@jrasell apologies for the confusion. I have read the contributing guide and the AI disclosure. I will sign the CLA now.

The CLA is still pending.

Signed-off-by: god032396-del <god032396@gmail.com>
@MD-Mushfiqur123 MD-Mushfiqur123 force-pushed the fix/issue-28048-consul-token-desc branch from 77aa926 to d53ed38 Compare June 13, 2026 02:25
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Nomad - Community Issues Triage Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

Improve description of Consul tokens to include client information

4 participants