consul: improve token description to include client info#28050
consul: improve token description to include client info#28050MD-Mushfiqur123 wants to merge 1 commit into
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
1 similar comment
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
|
Hi @MD-Mushfiqur123 and thanks for raising this PR. Before we can review this properly, we'll need you to sign the CLA, add a changelog entry that can be done via |
|
Internal tracking: https://hashicorp.atlassian.net/browse/NMD-1503 |
|
Friendly ping — this PR is ready for review. All CI checks are passing. |
Hi, I have already added a response here. |
|
The consul_testing.go mock now tracks LastRequestMeta, and Test_consulHook_prepareConsulTokens_Meta verifies that nomad_node_id is included in the token request. Still need the CLA signed — could you please handle that when you get a chance? |
Is that last comment to me, yourself, or an LLM? All committers need to sign the CLA as per HashiCorp/IBM policy. I will not start fully reviewing this PR until this is done. Please also ensure you have read out contributing guide and the AI disclosure section as I suspect an LLM has been used for this PR and comments. |
|
@jrasell apologies for the confusion. I have read the contributing guide and the AI disclosure. I will sign the CLA now. |
The CLA is still pending. |
Signed-off-by: god032396-del <god032396@gmail.com>
77aa926 to
d53ed38
Compare
Fixes #28048