Conversation
tehut
commented
Jun 11, 2026
| } | ||
| // Only set Count if not using FirstAvailable | ||
| if d.Count != nil { | ||
| if d.Count != nil && len(d.FirstAvailable) == 0 { |
add will_share to task device block fixes to get share working make sure WillShare != nil add helpers and test to exercise changes to createOffers add test helpers to generate shared devices and allocations add TestDeviceAccounter_AllocateAndReserveSharedDevices add willShare functionality to deviceAccounter.AddReserved fix bug that prevented reservation & add cases to TestDeviceChecker add cases to rank tests consolidate WillShare maps to AllocatedDeviceResource.WillShare refactor Task.WillShare to Task.ShareDevices fix comments tidying make plugin & structs DeviceSharing struct match proto generated struct simplify AddAllocs_Collision test and add nil check before using String() function in AddAllocs fix unkeyed literal Add dai.GetSharedByID helper and some refactor cleanup TEMP: plugin helper tidy DeviceSharing in structs.go to more closely mirror device/device.go bring api.go DeviceSharing struct into line with plugins/device.go replace GpuId with SharedDeviceId update GPU_ID references replace plugin device.DeviceSharing with Shared proto enum and cascade through api & structs fields Pass Shared by value now that its a typed string regression fix: not sure why i made the happy path unreachable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do not merge
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.