Support for disabling legacy IMDS. #134
Open
+165
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi, @lbajolet-hashicorp. I apologize for tagging directly, but I saw you were referenced on another open PR. Would it be possible to get some eyes on mine? Thank you. |
neumayer
reviewed
May 27, 2025
builder/oci/driver_oci.go
Outdated
| if d.cfg.InstanceOptions.AreLegacyImdsEndpointsDisabled != nil { | ||
| InstanceOptionsDetails := core.InstanceOptions{AreLegacyImdsEndpointsDisabled: d.cfg.InstanceOptions.AreLegacyImdsEndpointsDisabled} | ||
|
|
||
| instanceDetails.InstanceOptions = &InstanceOptionsDetails |
There was a problem hiding this comment.
Sorry @neumayer , I was out last week, so didn't have a chance to get to this until now. I pulled the instance options inline. Thank you.
| @@ -55,6 +55,10 @@ type ListImagesRequest struct { | |||
| Shape *string `mapstructure:"shape"` | |||
| } | |||
|
|
|||
| type InstanceOptionsConfig struct { | |||
| AreLegacyImdsEndpointsDisabled *bool `mapstructure:"are_legacy_imds_endpoints_disabled" required:"false"` | |||
There was a problem hiding this comment.
i think this can be added directly to config no need of a new instance
|
@cernertrevor please run make generate as some of the web docs are missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I am looking to offer an enhancement to packer-plugin-oracle to support the creation of instances with IMDSv1 support disabled (i.e. resolving #69 )
This is done by adding a new builder configuration option "instance_options" with a single attribute "are_legacy_imds_endpoints_disabled". This aligns with Oracle's CLI and Terraform's representation.
A few notes:
IMDS Disabled using the following builder configuration:
And without the configuration, the current behavior:
Thank you for this opportunity.
Closes #69