Skip to content

Workaround - Machine Learning Batch Endpoint identity#5204

Merged
sreallymatt merged 3 commits intohashicorp:mainfrom
promisinganuj:promisinganuj/ml-batch-endpoint-workaround
Mar 12, 2026
Merged

Workaround - Machine Learning Batch Endpoint identity#5204
sreallymatt merged 3 commits intohashicorp:mainfrom
promisinganuj:promisinganuj/ml-batch-endpoint-workaround

Conversation

@promisinganuj
Copy link
Copy Markdown
Contributor

@hashicorp-cla-app
Copy link
Copy Markdown

hashicorp-cla-app Bot commented Feb 5, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @promisinganuj - one question below to potentially avoid bumping into this again if the service team do not fix this in an upcoming version.

func (workaroundMachineLearning40149) IsApplicable(serviceName string, apiVersion sdkModels.APIVersion) bool {
serviceMatches := serviceName == "MachineLearningServices"
// 2025-06-01 is currently used for Machine Learning RPs, 2025-09-01 is the latest stable. So patching both.
apiVersionMatches := apiVersion.APIVersion == "2025-06-01" || apiVersion.APIVersion == "2025-09-01"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is present in all versions, is it worth omitting the version filter at this time? (Or are you aware of an incoming fix for future versions?).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackofallops , I have reached out to ST but haven't got any committment from them yet around the fix. Given that there is already another stable version 2025-12-01 released last week which still have this issue, it makes sense to remove the version filter. I have pushed this change.

Copy link
Copy Markdown
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @promisinganuj - One change required below, since there's no point keeping the additional logic at this time.

Thanks

Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>
@promisinganuj
Copy link
Copy Markdown
Contributor Author

@jackofallops , please have another look.

Copy link
Copy Markdown
Contributor

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @promisinganuj - LGTM ✅

@sreallymatt sreallymatt merged commit b356fd4 into hashicorp:main Mar 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants