Skip to content

importer - add number format float#5294

Merged
jackofallops merged 1 commit intomainfrom
mp/number-format
Mar 30, 2026
Merged

importer - add number format float#5294
jackofallops merged 1 commit intomainfrom
mp/number-format

Conversation

@sreallymatt
Copy link
Copy Markdown
Contributor

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so, please include appropriate closing keywords below.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.

Adding New API Version

Important

The primary purpose of API versions in this repository is to serve the Terraform Azure Providers. API versions are imported and maintained to support the providers' needs. If you would like to add an API version for use outside of the providers (e.g., another project consuming go-azure-sdk), please include a description of what you would like to use it for so we can evaluate the request.

  • I have verified the Service/API Version exists in the Azure REST API Specs.
  • I have followed the Service Import Guide.
  • This PR is for another downstream project and not for the Terraform Azure Providers.

Preview API Version

Important

We generally do not add preview API versions to go-azure-sdk, and we rarely support preview features in the provider. Exceptions require strong justification, such as when preview features have no GA date or no stable API version exists for a service. Please ensure you have thoroughly considered whether a preview API is truly necessary before proceeding.

  • This PR adds a preview API version
  1. Is there a stable (GA) version available?

  2. Why should we support this preview API?

  3. Do existing resources already use a preview API?

  4. What is the expected timeline for GA?

Changes to Tooling

  • I have added an explanation of what my changes do and why I'd like you to include them.
  • I have written new tests for my changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges.

Testing Command(s) Used:

# e.g., go test ./tools/generator-go-sdk/...

Testing Evidence:

Changes to Resource Config

Related Issue(s)

AI Assistance Disclosure

  • AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Note

If this PR changes meaningfully during the course of review, please update the title and description as required.

Copy link
Copy Markdown
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sreallymatt - LGTM

@jackofallops jackofallops merged commit 360f6dc into main Mar 30, 2026
7 checks passed
@jackofallops jackofallops deleted the mp/number-format branch March 30, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants