Skip to content

chore: Ensure build succeeds if go version 1.24 is used #3859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Ensure build succeeds if go version 1.24 is used #3859

wants to merge 1 commit into from

Conversation

mutahhir
Copy link
Member

Description

As of this commit, Go changes the location of the wasm_exec.js file. This PR updates our build script to be resilient to this change.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@mutahhir mutahhir requested a review from a team as a code owner April 22, 2025 12:37
@mutahhir mutahhir requested review from ansgarm and DanielMSchmidt and removed request for a team April 22, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielMSchmidt DanielMSchmidt DanielMSchmidt approved these changes

@ansgarm ansgarm Awaiting requested review from ansgarm ansgarm is a code owner automatically assigned from hashicorp/cdktf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mutahhir @DanielMSchmidt