fix(lib): DEP0044 in TerraformOutput #3861
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use deprecated `util.isArray`. Closes hashicorp#3860
gabegorelick
requested review from
mutahhir and
DanielMSchmidt
and removed request for
a team
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
gabegorelick
commented
Apr 23, 2025
| @@ -5,7 +5,6 @@ import { TerraformElement } from "./terraform-element"; | |||
| import { deepMerge } from "./util"; | |||
| import { ITerraformDependable } from "./terraform-dependable"; | |||
| import { Expression } from "."; | |||
| import { isArray } from "util"; | |||
There was a problem hiding this comment.
This dates to #1145. AFAICT the use of util.isArray was unintentional. Array.isArray is used everywhere else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use deprecated
util.isArray.Closes #3860
Related issue
Fixes #3860
Description
util.isArrayis deprecated in favor ofArray.isArray.Checklist