Skip to content

Allow for the use of service serving certificates with OpenShift#94

Open
benemon wants to merge 7 commits intohashicorp:mainfrom
benemon:resolve-conflicts
Open

Allow for the use of service serving certificates with OpenShift#94
benemon wants to merge 7 commits intohashicorp:mainfrom
benemon:resolve-conflicts

Conversation

@benemon
Copy link
Copy Markdown

@benemon benemon commented Oct 21, 2024

When TFE is deployed into OpenShift environments, a platform feature called 'service serving certificates' can be leveraged to generate, maintain, and rotate platform-issued certificates for components deployed onto it. Service Serving Certificates.

In the context of TFE, this feature allows us to sidestep the creation, deployment, and management of an internal certificate chain, by using one generated on behalf of the TFE workload by the OpenShift platform.

We can also use this feature to provide the platform's CA bundle to the TFE workload as a configmap, which in turn allows us to trust these service serving certificates.

Use of this feature, in conjunction with OpenShift Routes / ClusterIP services eases the onboarding of workloads into OpenShift, without requiring customisation of the helm chart, as all certificate operation will be offloaded to the platform.

This PR:

  • Enables support for Service Serving Certificates
  • Allows this to be enabled or disabled via the use of the sub flag openshift.serviceServingCertificates
  • Allows for the cluster CA bundle to be provided to the deployment if this flag is set
  • Allows for a route to be configured that specifically leverages service serving certificates between the router and the TFE workload if the flag is set.

@benemon benemon requested a review from a team as a code owner October 21, 2024 10:56
@nikolasrieble nikolasrieble requested a review from jkerry October 21, 2024 11:20
@p0pr0ck5
Copy link
Copy Markdown
Contributor

@benemon is this something we still want to pursue? If so, can you rebase to resolve the conflict? Thanks!

@benemon
Copy link
Copy Markdown
Author

benemon commented Mar 17, 2025

Hi @p0pr0ck5 - apologies, I lost focus on this. Let me review the conflict and see what needs to be resolved here.

@benemon
Copy link
Copy Markdown
Author

benemon commented Mar 17, 2025

@p0pr0ck5 I've resolved the conflicts as requested.

@benswinney
Copy link
Copy Markdown

Will this PR be merged for use on OpenShift?

@dtiesling-sphere
Copy link
Copy Markdown

Hi @nikolasrieble and @jkerry, we have a similar use case but want to use Google managed certs with a GKE Gateway that will terminate the SSL. I wanted to float the idea of a more generic option to have the helm chart ignore cert so people can configure routes independently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants