Add linterOptions to settings #1738
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #334
Fixes #855
This PR adds
linterOptionsto the language server settings. This includes the following TFLint configs, which I plan to use in subsequent PRs:options.linters.tflint.pathoptions.linters.tflint.configPathoptions.linters.tflint.lintOnSaveoptions.linters.tflint.timeoutPlease note that this change differs from that proposed in #855 in the following points:
binaryPathhas been changed topathto matchoptions.terraform.path.binaryFlagsis not supported. TFLint has multiple flags, and I'm not yet sure if they can be safely passed through terraform-ls.--configis likely to be needed at an early stage, onlyconfigPathis supported.timeoutis added. Because TFLint rules can be extended, it is necessary to set a timeout to ensure completion.Whether these changes are appropriate is open to debate. I would be happy to discuss it here.
If there are any other matters that need to be discussed in advance regarding this issue, please feel free to let me know. Thank you.