feat(completion): support deep completion for indexed variable traversals#2109
Open
Oussama-El-Amrani wants to merge 2 commits intohashicorp:mainfrom
Open
feat(completion): support deep completion for indexed variable traversals#2109Oussama-El-Amrani wants to merge 2 commits intohashicorp:mainfrom
Oussama-El-Amrani wants to merge 2 commits intohashicorp:mainfrom
Conversation
…sals Implement discovery of literal index steps (e.g., var.foo[0]) by scanning module files. This allows the LSP to provide autocompletion for deep attributes within complex variables that were previously opaque. - Scans module files for 'var.' traversals. - Recursively expands cty.Type targets based on discovered index keys. - Adds comprehensive tests for nested objects, lists, and maps. - Fixes hashicorp#653
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements discovery of literal index steps (e.g.,
var.foo[0]orvar.map["key"]) by scanning module files. This allows the Language Server to provide autocompletion for deep attributes within complex variables (lists, maps, and objects) that were previously opaque.Problem
Currently,
terraform-lsstruggles to provide completion for nested attributes when they are accessed through an index or key, because indexing every possible value for every variable is computationally expensive. This is a major part of the limitation tracked in #653.Solution
Instead of trying to index all possible paths, this PR uses a "best-effort discovery" mechanism:
var.traversals.cty.Typetargets for these specific discovered keys.Changes
internal/features/modules/decoder/references.goto include the discovery logic.internal/langserver/handlers/complete_test.go.Fixes #653