feat: improve custom type generation and fix duplicate definitions #223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses several issues related to code generation, specifically improving how custom types are handled.
Key Changes
nested_object_value_to_object_value.gotmplto simplify the value assignment logic. This makes the generated code cleaner and less error-prone.Examples
Simplified Nested Object Assignment
Previously, the generated code for checking null/unknown values for nested objects was verbose:
Now, it is directly assigned, relying on the underlying framework types to handle the state correctly:
Why these changes were necessary
Tests
Updated
internal/schema/custom_nested_object_test.goto match the simplified code generation logic.ListNested,MapNested, andSetNestedtypes in the template to ensure consistency.internal/schemapass.Checklists