aws_ssm_resource_data_sync - Add DestinationDataSharingType

[melbit-michaelw]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18330

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

Unfortunately, the AWS API doesn't return the information (or lack thereof) about the DestinationDataSharing configuration. As a result, I've had to make the assumption that the information in the state file is accurate, and use that in conjunction with the data returned as part of the Read.

This works successfully in that adding or removing the destination_data_sharing_type from the configuration will trigger a destroy/create with the new value, but doesn't work for importing (since there is no information about whether it is an Organization data sharing type).

I don't know whether this is the right approach, and I couldn't find anything similar to use as an example, so I'm looking for guidance on whether I've done the right thing (in which case I'll try to come up with some suitable tests, but that might be difficult since they'll require an Organization in order to test that functionality).

[dhohengassner]

@melbit-michaelw nice job - was going to prepare something similar 👍

Think if we do not get the info from API not much we can do on the input 😄

Would be great to get some feedback from Hashicorp or get this merged soon. Any updates here?

[melbit-michaelw]

@jar-b / @YakDriver / @ewbankkit - Apologies for reaching out directly, but this has been sitting for over a year with no feedback.

It's probably not in a suitable state for merging since it doesn't have tests which is why I've left it as 'draft', but if I could please get some feedback on whether the approach taken is suitable given the limitations of what's returned by the AWS API, I can investigate adding tests and/or re-working based on the feedback if a more suitable approach is identified.

Thank you for your time.

[arongate]

Hello, any news on this ?

[github-actions]

This draft pull request is being closed because it has been inactive for 60 days ⏳. This helps our maintainers find and focus on active contributions.

If you would like to continue working on this, please reopen the pull request and mark it as ready for review when complete. Thank you!

[github-actions]

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

[gdavison]

Acceptance test results

Single account:

$ make testacc PKG=ssm TESTS=TestAccSSMResourceDataSync_

--- SKIP: TestAccSSMResourceDataSync_DestinationDataSharing_organization (0.33s)
--- PASS: TestAccSSMResourceDataSync_disappears (28.65s)
--- PASS: TestAccSSMResourceDataSync_basic (34.63s)
--- PASS: TestAccSSMResourceDataSync_DestinationDataSharing_sameAccount (34.87s)
--- PASS: TestAccSSMResourceDataSync_DestinationDataSharing_add (45.44s)
--- PASS: TestAccSSMResourceDataSync_DestinationDataSharing_remove (45.53s)
--- PASS: TestAccSSMResourceDataSync_Update_s3DestinationPrefix (47.97s)

Organization:

$ make testacc PKG=ssm TESTS=TestAccSSMResourceDataSync_DestinationDataSharing_organization AWS_PROFILE=<org member account> AWS_ALTERNATE_PROFILE=<org management account>

--- PASS: TestAccSSMResourceDataSync_DestinationDataSharing_organization (56.42s)

[ewbankkit]

LGTM 🚀.

[github-actions]

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.