WIP DMS: Pass timeout through function calls#37136
Closed
nijave wants to merge 3 commits into
Closed
Conversation
Contributor
Community NoteVoting for Prioritization
For Submitters
|
github-actions
Bot
added
size/S
terraform-aws-provider
Bot
added
the
needs-triage
github-actions
Bot
added
size/M
nijave
changed the title
nijave
force-pushed
the
nv-dms-passthru-timeout
branch
3 times, most recently
from
b09397a to
559b0cb
Compare
justinretzolk
added
enhancement
Contributor
Author
|
Did a manual test in our environment and looks like I'm not hitting the same errors as before. Here's timings I believe creation/deletion increases over time since these are all on the same instance and the changes get internally queued on the AWS side (with limited concurrency) |
Contributor
Author
|
I did hit now which I think must be a result of how connection testing works. All these DMS tasks use different PG databases/tables and send to the same target (S3) on the same replication instance |
These hardcoded timeouts in waiters are being exceeded and there's currently no way to configure them. This passes through remaining time using context.WithTimeout
nijave
force-pushed
the
nv-dms-passthru-timeout
branch
3 times, most recently
from
58457fd to
c6f0904
Compare
- Check to see if there's already an existing successful test before starting a new one - Don't fail out of the test loop if a connection is already being tested - Add replication instance filter to TestConnection waiter since tests are based on (replication instance, endpoint)
nijave
force-pushed
the
nv-dms-passthru-timeout
branch
from
c6f0904 to
478c123
Compare
|
@justinretzolk any chance can this get reviewed? I had to write a couple of bash script lines to ensure that the dms tasks reach a certain state before our |
Contributor
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These hard coded timeouts in waiters are being exceeded and there's currently no way to configure them. This passes through remaining time
Description
More configurable DMS task timeouts.
Relations
Closes #37026
References
Output from Acceptance Testing
TODO
- Update DMS task resource so thetimeout {}block works- Switch to using ctx.WithTimeout instead of passing around time.Duration