Skip to content

Conversation

@Klopklopi
Copy link
Contributor

Description

This merge request introduce the implementation of private integration with ALB for REST API (Apigateway service). This is done by changing the aws_api_gateway_integration and make it support the VPC Link V2 with ALB Integration.

Relations

Closes ##45230

References

Architecture
Documentation

Output from Acceptance Testing

make testacc PKG=apigateway T=TestAccAPIGatewayIntegration_vpcLinkV2
make: Running acceptance tests on branch: 🌿 vpc_link_v2_alb_support 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/apigateway/... -v -count 1 -parallel 20 -run='TestAccAPIGatewayIntegration_vpcLinkV2'  -timeout 360m -vet=off
2025/11/28 12:55:28 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/28 12:55:28 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccAPIGatewayIntegration_vpcLinkV2WithALB
=== PAUSE TestAccAPIGatewayIntegration_vpcLinkV2WithALB
=== RUN   TestAccAPIGatewayIntegration_vpcLinkV2Update
=== PAUSE TestAccAPIGatewayIntegration_vpcLinkV2Update
=== CONT  TestAccAPIGatewayIntegration_vpcLinkV2WithALB
=== CONT  TestAccAPIGatewayIntegration_vpcLinkV2Update
--- PASS: TestAccAPIGatewayIntegration_vpcLinkV2WithALB (237.61s)
--- PASS: TestAccAPIGatewayIntegration_vpcLinkV2Update (440.23s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apigateway 446.868s

@Klopklopi Klopklopi requested a review from a team as a code owner November 28, 2025 12:10
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/apigateway Issues and PRs that pertain to the apigateway service. provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR. labels Nov 28, 2025
@ziaulrehman40
Copy link

I need this, thanks for the implementation.

@sunilkamat85
Copy link

Thank you for this implementation. This one is quite critical for my project. Generally how long does it take to get merged and released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants