Skip to content

Conversation

@madhavvishnubhatta
Copy link
Contributor

@madhavvishnubhatta madhavvishnubhatta commented Nov 28, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Relations

Closes #45250

References

https://aws.amazon.com/blogs/aws/aws-transfer-family-sftp-connectors-now-support-vpc-based-connectivity/
https://docs.aws.amazon.com/cli/latest/reference/transfer/create-connector.html
https://docs.aws.amazon.com/cli/latest/reference/transfer/update-connector.html

Output from Acceptance Testing

% make testacc PKG=transfer TESTS=TestAccTransferConnector
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-vpc_support_for_sftp_connector 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransferConnector'  -timeout 360m -vet=off
2025/12/01 12:03:30 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/01 12:03:30 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccTransferConnectorDataSource_basic
=== PAUSE TestAccTransferConnectorDataSource_basic
=== RUN   TestAccTransferConnectorDataSource_egressConfig
=== PAUSE TestAccTransferConnectorDataSource_egressConfig
=== RUN   TestAccTransferConnector_basic
--- PASS: TestAccTransferConnector_basic (25.76s)
=== RUN   TestAccTransferConnector_sftpConfig
--- PASS: TestAccTransferConnector_sftpConfig (15.87s)
=== RUN   TestAccTransferConnector_securityPolicyName
--- PASS: TestAccTransferConnector_securityPolicyName (15.80s)
=== RUN   TestAccTransferConnector_disappears
--- PASS: TestAccTransferConnector_disappears (13.99s)
=== RUN   TestAccTransferConnector_egressConfig
--- PASS: TestAccTransferConnector_egressConfig (78.60s)
=== RUN   TestAccTransferConnector_egressConfigUpdate
--- PASS: TestAccTransferConnector_egressConfigUpdate (76.69s)
=== RUN   TestAccTransferConnector_tags
--- PASS: TestAccTransferConnector_tags (35.41s)
=== CONT  TestAccTransferConnectorDataSource_basic
=== CONT  TestAccTransferConnectorDataSource_egressConfig
--- PASS: TestAccTransferConnectorDataSource_basic (13.67s)
--- PASS: TestAccTransferConnectorDataSource_egressConfig (88.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/transfer   350.406s

@madhavvishnubhatta madhavvishnubhatta requested a review from a team as a code owner November 28, 2025 13:39
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/transfer Issues and PRs that pertain to the transfer service. size/XL Managed by automation to categorize the size of a PR. partner Contribution from a partner. labels Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. service/transfer Issues and PRs that pertain to the transfer service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support VPC based connectivity for SFTP connectors

1 participant