Skip to content

Conversation

@rshade
Copy link
Contributor

@rshade rshade commented Dec 1, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds REPLICATING state support and diff suppression to prevent perpetual drift when AWS sets protection.replication_overwrite to REPLICATING for replication destination file systems.

Relations

Closes #36811

References

Output from Acceptance Testing

make: Running acceptance tests on branch: 🌿 rshade/efs-refresh 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/efs/... -v -count 1 -parallel 20 -run='TestAccEFSFileSystem_'  -timeout 360m -vet=off
2025/12/01 16:03:48 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/01 16:03:48 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccEFSFileSystem_basic
=== PAUSE TestAccEFSFileSystem_basic
=== RUN   TestAccEFSFileSystem_disappears
=== PAUSE TestAccEFSFileSystem_disappears
=== RUN   TestAccEFSFileSystem_performanceMode
=== PAUSE TestAccEFSFileSystem_performanceMode
=== RUN   TestAccEFSFileSystem_protection
=== PAUSE TestAccEFSFileSystem_protection
=== RUN   TestAccEFSFileSystem_availabilityZoneName
=== PAUSE TestAccEFSFileSystem_availabilityZoneName
=== RUN   TestAccEFSFileSystem_tags
=== PAUSE TestAccEFSFileSystem_tags
=== RUN   TestAccEFSFileSystem_kmsKey
=== PAUSE TestAccEFSFileSystem_kmsKey
=== RUN   TestAccEFSFileSystem_kmsWithoutEncryption
=== PAUSE TestAccEFSFileSystem_kmsWithoutEncryption
=== RUN   TestAccEFSFileSystem_provisionedThroughputInMibps
=== PAUSE TestAccEFSFileSystem_provisionedThroughputInMibps
=== RUN   TestAccEFSFileSystem_throughputMode
=== PAUSE TestAccEFSFileSystem_throughputMode
=== RUN   TestAccEFSFileSystem_lifecyclePolicy
=== PAUSE TestAccEFSFileSystem_lifecyclePolicy
=== CONT  TestAccEFSFileSystem_basic
=== CONT  TestAccEFSFileSystem_kmsKey
=== CONT  TestAccEFSFileSystem_throughputMode
=== CONT  TestAccEFSFileSystem_provisionedThroughputInMibps
=== CONT  TestAccEFSFileSystem_kmsWithoutEncryption
=== CONT  TestAccEFSFileSystem_protection
=== CONT  TestAccEFSFileSystem_tags
=== CONT  TestAccEFSFileSystem_availabilityZoneName
=== CONT  TestAccEFSFileSystem_performanceMode
=== CONT  TestAccEFSFileSystem_lifecyclePolicy
=== CONT  TestAccEFSFileSystem_disappears
--- PASS: TestAccEFSFileSystem_kmsWithoutEncryption (57.33s)
--- PASS: TestAccEFSFileSystem_disappears (93.11s)
--- PASS: TestAccEFSFileSystem_performanceMode (110.45s)
--- PASS: TestAccEFSFileSystem_availabilityZoneName (122.22s)
--- PASS: TestAccEFSFileSystem_kmsKey (131.74s)
--- PASS: TestAccEFSFileSystem_basic (132.57s)
--- PASS: TestAccEFSFileSystem_protection (144.02s)
--- PASS: TestAccEFSFileSystem_provisionedThroughputInMibps (159.45s)
--- PASS: TestAccEFSFileSystem_throughputMode (159.56s)
--- PASS: TestAccEFSFileSystem_tags (215.18s)
--- PASS: TestAccEFSFileSystem_lifecyclePolicy (239.02s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/efs        239.197s
...

@rshade rshade requested a review from a team as a code owner December 1, 2025 21:01
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/efs Issues and PRs that pertain to the efs service. size/M Managed by automation to categorize the size of a PR. labels Dec 1, 2025
…NG protection state

Fixes hashicorp#36811

Adds REPLICATING state support and diff suppression to prevent perpetual
drift when AWS sets protection.replication_overwrite to REPLICATING for
replication destination file systems.
@rshade rshade force-pushed the rshade/efs-refresh branch from 0701f48 to 4218cce Compare December 1, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-triage Waiting for first response or review from a maintainer. service/efs Issues and PRs that pertain to the efs service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Active replication configuration causes a "change" to be reported in a plan when no change has occurred

1 participant