Skip to content

resource/aws_securityhub_insight: Schema caching#47912

Merged
gdavison merged 3 commits into
mainfrom
td-securityhub-filters-schema
May 21, 2026
Merged

resource/aws_securityhub_insight: Schema caching#47912
gdavison merged 3 commits into
mainfrom
td-securityhub-filters-schema

Conversation

@gdavison
Copy link
Copy Markdown
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds schema caching to aws_securityhub_insight resource types

Iteration Count Time per Operation Bytes per Operation Allocations per Operation
Before 130 8997627 ns/op 17,803,070 B/op 95,370 allocs/op
After 130 9147911 ns/op 17,650,277 B/op 94,749 allocs/op

Relations

Relates #47003

@gdavison gdavison requested a review from a team as a code owner May 14, 2026 18:02
@dosubot dosubot Bot added the enhancement Requests to existing resources that expand the functionality or scope. label May 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/securityhub Issues and PRs that pertain to the securityhub service. linter Pertains to changes to or issues with the various linters. size/XL Managed by automation to categorize the size of a PR. labels May 14, 2026
Base automatically changed from td-quicksight-update-schema-more to main May 19, 2026 18:05
Copy link
Copy Markdown
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison merged commit 5273108 into main May 21, 2026
65 checks passed
@gdavison gdavison deleted the td-securityhub-filters-schema branch May 21, 2026 15:56
@github-actions
Copy link
Copy Markdown
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions Bot added this to the v6.47.0 milestone May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Requests to existing resources that expand the functionality or scope. linter Pertains to changes to or issues with the various linters. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/securityhub Issues and PRs that pertain to the securityhub service. size/XL Managed by automation to categorize the size of a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants