Skip to content

f/aws_route53_zone_association: Add RI and List support#47950

Merged
subham-ibmhc merged 6 commits into
mainfrom
f-list-resource-aws_route53_zone_association
May 18, 2026
Merged

f/aws_route53_zone_association: Add RI and List support#47950
subham-ibmhc merged 6 commits into
mainfrom
f-list-resource-aws_route53_zone_association

Conversation

@subham-ibmhc
Copy link
Copy Markdown
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds RI and list support for aws_route53_zone_association resource.

Relations

Closes #47246

Output from Acceptance Testing

% make t T=TestAccRoute53ZoneAssociation_ K=route53
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-list-resource-aws_route53_zone_association 🌿...
TF_ACC=1 go1.26.3 test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53ZoneAssociation_'  -timeout 360m -vet=off
2026/05/18 12:04:27 Creating Terraform AWS Provider (SDKv2-style)...
2026/05/18 12:04:27 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccRoute53ZoneAssociation_Identity_basic
=== PAUSE TestAccRoute53ZoneAssociation_Identity_basic
=== RUN   TestAccRoute53ZoneAssociation_Identity_ExistingResource_basic
=== PAUSE TestAccRoute53ZoneAssociation_Identity_ExistingResource_basic
=== RUN   TestAccRoute53ZoneAssociation_Identity_ExistingResource_noRefreshNoChange
=== PAUSE TestAccRoute53ZoneAssociation_Identity_ExistingResource_noRefreshNoChange
=== RUN   TestAccRoute53ZoneAssociation_basic
=== PAUSE TestAccRoute53ZoneAssociation_basic
=== RUN   TestAccRoute53ZoneAssociation_disappears
=== PAUSE TestAccRoute53ZoneAssociation_disappears
=== RUN   TestAccRoute53ZoneAssociation_disappears_VPC
=== PAUSE TestAccRoute53ZoneAssociation_disappears_VPC
=== RUN   TestAccRoute53ZoneAssociation_disappears_Zone
=== PAUSE TestAccRoute53ZoneAssociation_disappears_Zone
=== RUN   TestAccRoute53ZoneAssociation_crossAccount
=== PAUSE TestAccRoute53ZoneAssociation_crossAccount
=== RUN   TestAccRoute53ZoneAssociation_crossRegion
=== PAUSE TestAccRoute53ZoneAssociation_crossRegion
=== RUN   TestAccRoute53ZoneAssociation_crossAccountAndRegion
=== PAUSE TestAccRoute53ZoneAssociation_crossAccountAndRegion
=== CONT  TestAccRoute53ZoneAssociation_Identity_basic
=== CONT  TestAccRoute53ZoneAssociation_disappears_VPC
=== CONT  TestAccRoute53ZoneAssociation_basic
=== CONT  TestAccRoute53ZoneAssociation_Identity_ExistingResource_noRefreshNoChange
=== CONT  TestAccRoute53ZoneAssociation_crossAccount
=== CONT  TestAccRoute53ZoneAssociation_Identity_ExistingResource_basic
=== CONT  TestAccRoute53ZoneAssociation_crossRegion
=== CONT  TestAccRoute53ZoneAssociation_crossAccountAndRegion
=== CONT  TestAccRoute53ZoneAssociation_disappears
=== CONT  TestAccRoute53ZoneAssociation_disappears_Zone
=== NAME  TestAccRoute53ZoneAssociation_crossAccount
    zone_association_test.go:130: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRoute53ZoneAssociation_crossAccount (1.09s)
=== NAME  TestAccRoute53ZoneAssociation_crossAccountAndRegion
    zone_association_test.go:192: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRoute53ZoneAssociation_crossAccountAndRegion (1.09s)
--- PASS: TestAccRoute53ZoneAssociation_disappears_Zone (282.02s)
--- PASS: TestAccRoute53ZoneAssociation_disappears (360.38s)
--- PASS: TestAccRoute53ZoneAssociation_disappears_VPC (360.98s)
--- PASS: TestAccRoute53ZoneAssociation_basic (363.02s)
--- PASS: TestAccRoute53ZoneAssociation_Identity_basic (380.24s)
--- PASS: TestAccRoute53ZoneAssociation_Identity_ExistingResource_noRefreshNoChange (392.59s)
--- PASS: TestAccRoute53ZoneAssociation_Identity_ExistingResource_basic (396.54s)
--- PASS: TestAccRoute53ZoneAssociation_crossRegion (399.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    404.050s

% make t T=TestAccRoute53ZoneAssociation_List_ K=route53
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-list-resource-aws_route53_zone_association 🌿...
TF_ACC=1 go1.26.3 test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53ZoneAssociation_List_'  -timeout 360m -vet=off
2026/05/18 12:44:23 Creating Terraform AWS Provider (SDKv2-style)...
2026/05/18 12:44:23 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccRoute53ZoneAssociation_List_basic
=== PAUSE TestAccRoute53ZoneAssociation_List_basic
=== RUN   TestAccRoute53ZoneAssociation_List_includeResource
=== PAUSE TestAccRoute53ZoneAssociation_List_includeResource
=== CONT  TestAccRoute53ZoneAssociation_List_basic
=== CONT  TestAccRoute53ZoneAssociation_List_includeResource
--- PASS: TestAccRoute53ZoneAssociation_List_includeResource (375.12s)
--- PASS: TestAccRoute53ZoneAssociation_List_basic (376.35s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    381.613s
...

```console
% make t T=TestAccRoute53ZoneAssociation_ K=route53
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-list-resource-aws_route53_zone_association 🌿...
TF_ACC=1 go1.26.3 test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53ZoneAssociation_'  -timeout 360m -vet=off
2026/05/18 12:04:27 Creating Terraform AWS Provider (SDKv2-style)...
2026/05/18 12:04:27 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccRoute53ZoneAssociation_Identity_basic
=== PAUSE TestAccRoute53ZoneAssociation_Identity_basic
=== RUN   TestAccRoute53ZoneAssociation_Identity_ExistingResource_basic
=== PAUSE TestAccRoute53ZoneAssociation_Identity_ExistingResource_basic
=== RUN   TestAccRoute53ZoneAssociation_Identity_ExistingResource_noRefreshNoChange
=== PAUSE TestAccRoute53ZoneAssociation_Identity_ExistingResource_noRefreshNoChange
=== RUN   TestAccRoute53ZoneAssociation_basic
=== PAUSE TestAccRoute53ZoneAssociation_basic
=== RUN   TestAccRoute53ZoneAssociation_disappears
=== PAUSE TestAccRoute53ZoneAssociation_disappears
=== RUN   TestAccRoute53ZoneAssociation_disappears_VPC
=== PAUSE TestAccRoute53ZoneAssociation_disappears_VPC
=== RUN   TestAccRoute53ZoneAssociation_disappears_Zone
=== PAUSE TestAccRoute53ZoneAssociation_disappears_Zone
=== RUN   TestAccRoute53ZoneAssociation_crossAccount
=== PAUSE TestAccRoute53ZoneAssociation_crossAccount
=== RUN   TestAccRoute53ZoneAssociation_crossRegion
=== PAUSE TestAccRoute53ZoneAssociation_crossRegion
=== RUN   TestAccRoute53ZoneAssociation_crossAccountAndRegion
=== PAUSE TestAccRoute53ZoneAssociation_crossAccountAndRegion
=== CONT  TestAccRoute53ZoneAssociation_Identity_basic
=== CONT  TestAccRoute53ZoneAssociation_disappears_VPC
=== CONT  TestAccRoute53ZoneAssociation_basic
=== CONT  TestAccRoute53ZoneAssociation_Identity_ExistingResource_noRefreshNoChange
=== CONT  TestAccRoute53ZoneAssociation_crossAccount
=== CONT  TestAccRoute53ZoneAssociation_Identity_ExistingResource_basic
=== CONT  TestAccRoute53ZoneAssociation_crossRegion
=== CONT  TestAccRoute53ZoneAssociation_crossAccountAndRegion
=== CONT  TestAccRoute53ZoneAssociation_disappears
=== CONT  TestAccRoute53ZoneAssociation_disappears_Zone
=== NAME  TestAccRoute53ZoneAssociation_crossAccount
    zone_association_test.go:130: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRoute53ZoneAssociation_crossAccount (1.09s)
=== NAME  TestAccRoute53ZoneAssociation_crossAccountAndRegion
    zone_association_test.go:192: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRoute53ZoneAssociation_crossAccountAndRegion (1.09s)
--- PASS: TestAccRoute53ZoneAssociation_disappears_Zone (282.02s)
--- PASS: TestAccRoute53ZoneAssociation_disappears (360.38s)
--- PASS: TestAccRoute53ZoneAssociation_disappears_VPC (360.98s)
--- PASS: TestAccRoute53ZoneAssociation_basic (363.02s)
--- PASS: TestAccRoute53ZoneAssociation_Identity_basic (380.24s)
--- PASS: TestAccRoute53ZoneAssociation_Identity_ExistingResource_noRefreshNoChange (392.59s)
--- PASS: TestAccRoute53ZoneAssociation_Identity_ExistingResource_basic (396.54s)
--- PASS: TestAccRoute53ZoneAssociation_crossRegion (399.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    404.050s
```
```console
% make t T=TestAccRoute53ZoneAssociation_List_ K=route53
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-list-resource-aws_route53_zone_association 🌿...
TF_ACC=1 go1.26.3 test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53ZoneAssociation_List_'  -timeout 360m -vet=off
2026/05/18 12:44:23 Creating Terraform AWS Provider (SDKv2-style)...
2026/05/18 12:44:23 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccRoute53ZoneAssociation_List_basic
=== PAUSE TestAccRoute53ZoneAssociation_List_basic
=== RUN   TestAccRoute53ZoneAssociation_List_includeResource
=== PAUSE TestAccRoute53ZoneAssociation_List_includeResource
=== CONT  TestAccRoute53ZoneAssociation_List_basic
=== CONT  TestAccRoute53ZoneAssociation_List_includeResource
--- PASS: TestAccRoute53ZoneAssociation_List_includeResource (375.12s)
--- PASS: TestAccRoute53ZoneAssociation_List_basic (376.35s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    381.613s
```
@github-actions
Copy link
Copy Markdown
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53 Issues and PRs that pertain to the route53 service. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/XL Managed by automation to categorize the size of a PR. labels May 18, 2026
@subham-ibmhc subham-ibmhc marked this pull request as ready for review May 18, 2026 07:43
@subham-ibmhc subham-ibmhc requested a review from a team as a code owner May 18, 2026 07:43
@dosubot dosubot Bot added the new-list-resource Introduces list resource support. label May 18, 2026
@subham-ibmhc subham-ibmhc added the rnd-ind-provider rnd-ind-provider label May 18, 2026
Copy link
Copy Markdown
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@subham-ibmhc subham-ibmhc merged commit 1ee92a4 into main May 18, 2026
75 checks passed
@subham-ibmhc subham-ibmhc deleted the f-list-resource-aws_route53_zone_association branch May 18, 2026 16:58
@github-actions
Copy link
Copy Markdown
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions Bot added this to the v6.46.0 milestone May 18, 2026
@github-actions github-actions Bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This functionality has been released in v6.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-list-resource Introduces list resource support. rnd-ind-provider rnd-ind-provider service/route53 Issues and PRs that pertain to the route53 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List: aws_route53_zone_association

2 participants