Skip to content

🤖🤖🤖 d/aws_ec2_local_gateway_virtual_interface: Add outpost_lag_id and local_gateway_virtual_interface_group_id attributes#47974

Merged
ewbankkit merged 2 commits into
hashicorp:mainfrom
BenjaminSaintCyr:f-aws_ec2_local_gateway_virtual_interface-add-attributes
May 20, 2026
Merged

🤖🤖🤖 d/aws_ec2_local_gateway_virtual_interface: Add outpost_lag_id and local_gateway_virtual_interface_group_id attributes#47974
ewbankkit merged 2 commits into
hashicorp:mainfrom
BenjaminSaintCyr:f-aws_ec2_local_gateway_virtual_interface-add-attributes

Conversation

@BenjaminSaintCyr
Copy link
Copy Markdown

@BenjaminSaintCyr BenjaminSaintCyr commented May 19, 2026

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

No changes to security controls (access controls, encryption, logging) are introduced by this pull request.

Description

Adds two missing computed attributes to the aws_ec2_local_gateway_virtual_interface data source that the AWS API already returns via DescribeLocalGatewayVirtualInterfaces:

  • outpost_lag_id — The ID of the Outpost LAG the virtual interface is attached to.
  • local_gateway_virtual_interface_group_id — The ID of the Local Gateway Virtual Interface Group the VIF belongs to.

Both fields are already populated on the SDK LocalGatewayVirtualInterface type and simply needed to be plumbed through the schema.

Relations

Closes #47943

References

Output from Acceptance Testing

% make testacc TESTS=TestAccEC2OutpostsLocalGatewayVirtualInterfaceDataSource PKG=ec2

...

AI Usage Disclosure

This pull request was prepared with assistance from an AI agent — specifically, a custom agent running inside Claude Code. The agent was configured for this repository (branching conventions, skaff usage, make gen awareness, no manual edits to _gen.go, smarterr patterns, AutoFlex, identity generators, acceptance-test scaffolding) and used for requirements analysis, code generation, test verification, and documentation. Every line has been reviewed by the human contributor, who has verified the code compiles and understands each design decision. Per the project's AI Usage Policy, "🤖🤖🤖" is included in the PR title.

…al_gateway_virtual_interface_group_id attributes
@BenjaminSaintCyr BenjaminSaintCyr requested a review from a team as a code owner May 19, 2026 17:40
@dosubot dosubot Bot added the enhancement Requests to existing resources that expand the functionality or scope. label May 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions Bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2outposts Issues and PRs that pertain to the ec2outposts service. size/XS Managed by automation to categorize the size of a PR. labels May 19, 2026
@BenjaminSaintCyr BenjaminSaintCyr marked this pull request as draft May 19, 2026 18:38
@BenjaminSaintCyr BenjaminSaintCyr changed the title d/aws_ec2_local_gateway_virtual_interface: Add outpost_lag_id and local_gateway_virtual_interface_group_id attributes 🤖🤖🤖 d/aws_ec2_local_gateway_virtual_interface: Add outpost_lag_id and local_gateway_virtual_interface_group_id attributes May 19, 2026
Copy link
Copy Markdown

@FireballDWF FireballDWF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 20, 2026
@BenjaminSaintCyr BenjaminSaintCyr marked this pull request as ready for review May 20, 2026 13:26
@ewbankkit ewbankkit self-assigned this May 20, 2026
@github-actions github-actions Bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 20, 2026
Copy link
Copy Markdown
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

The swissshepherd errors were addressed in #47976.

@ewbankkit
Copy link
Copy Markdown
Contributor

@BenjaminSaintCyr Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c550089 into hashicorp:main May 20, 2026
55 of 56 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions Bot added this to the v6.46.0 milestone May 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This functionality has been released in v6.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions Bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2outposts Issues and PRs that pertain to the ec2outposts service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

data/aws_ec2_local_gateway_virtual_interface: Add outpost_lag_id and local_gateway_virtual_interface_group_id attributes

3 participants