Skip to content

New resource: aws_xray_indexing_rule#47975

Merged
ewbankkit merged 9 commits into
mainfrom
f-r/aws_xray_indexing_rule
May 20, 2026
Merged

New resource: aws_xray_indexing_rule#47975
ewbankkit merged 9 commits into
mainfrom
f-r/aws_xray_indexing_rule

Conversation

@ewbankkit
Copy link
Copy Markdown
Contributor

@ewbankkit ewbankkit commented May 19, 2026

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds the aws_xray_indexing_rule resource.
No corresponding list resource as only the rule named Default is supported.

Relations

Closes #43077.
Closes #44779.
Closes #47299.
Relates #44742.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccXRayIndexingRule_serial' PKG=xray
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Validating schemas
ok      github.com/hashicorp/terraform-provider-aws/internal/provider/sdkv2     6.124s
ok      github.com/hashicorp/terraform-provider-aws/internal/provider/framework 5.968s
make: Running acceptance tests on branch: 🌿 f-r/aws_xray_indexing_rule 🌿...
TF_ACC=1 go1.26.3 test ./internal/service/xray/... -v -count 1 -parallel 20  -run=TestAccXRayIndexingRule_serial -timeout 360m -vet=off -buildvcs=false
2026/05/19 14:08:26 Creating Terraform AWS Provider (SDKv2-style)...
2026/05/19 14:08:26 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccXRayIndexingRule_serial
=== PAUSE TestAccXRayIndexingRule_serial
=== CONT  TestAccXRayIndexingRule_serial
=== RUN   TestAccXRayIndexingRule_serial/basic
=== RUN   TestAccXRayIndexingRule_serial/Identity
=== RUN   TestAccXRayIndexingRule_serial/Identity/basic
=== RUN   TestAccXRayIndexingRule_serial/Identity/RegionOverride
--- PASS: TestAccXRayIndexingRule_serial (62.57s)
    --- PASS: TestAccXRayIndexingRule_serial/basic (14.46s)
    --- PASS: TestAccXRayIndexingRule_serial/Identity (48.11s)
        --- PASS: TestAccXRayIndexingRule_serial/Identity/basic (25.00s)
        --- PASS: TestAccXRayIndexingRule_serial/Identity/RegionOverride (23.12s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/xray       68.664s

ewbankkit added 6 commits May 19, 2026 08:37
% make testacc TESTARGS='-run=TestAccXRayIndexingRule_serial/^basic$$' PKG=xray
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Validating schemas
ok      github.com/hashicorp/terraform-provider-aws/internal/provider/sdkv2     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/provider/framework (cached)
make: Running acceptance tests on branch: 🌿 f-r/aws_xray_indexing_rule 🌿...
TF_ACC=1 go1.26.3 test ./internal/service/xray/... -v -count 1 -parallel 20  -run=TestAccXRayIndexingRule_serial/^basic$ -timeout 360m -vet=off -buildvcs=false
2026/05/19 12:21:59 Creating Terraform AWS Provider (SDKv2-style)...
2026/05/19 12:21:59 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccXRayIndexingRule_serial
=== PAUSE TestAccXRayIndexingRule_serial
=== CONT  TestAccXRayIndexingRule_serial
=== RUN   TestAccXRayIndexingRule_serial/basic
--- PASS: TestAccXRayIndexingRule_serial (14.59s)
    --- PASS: TestAccXRayIndexingRule_serial/basic (14.59s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/xray       20.504s
# Conflicts:
#	internal/service/xray/exports_test.go
@github-actions
Copy link
Copy Markdown
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/xray Issues and PRs that pertain to the xray service. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels May 19, 2026
@ewbankkit ewbankkit marked this pull request as ready for review May 19, 2026 18:14
@ewbankkit ewbankkit requested a review from a team as a code owner May 19, 2026 18:14
@dosubot dosubot Bot added the new-resource Introduces a new resource. label May 19, 2026
Copy link
Copy Markdown
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Team should discuss whether it's still useful to have list resources for completeness and config generation even though some, like this one, would be sort of useless otherwise.

LGTM 🎉

% make t T=TestAccXRayIndexingRule_serial K=xray
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-r/aws_xray_indexing_rule 🌿...
TF_ACC=1 go1.26.3 test ./internal/service/xray/... -v -count 1 -parallel 20 -run='TestAccXRayIndexingRule_serial'  -timeout 360m -vet=off
2026/05/19 16:54:42 Creating Terraform AWS Provider (SDKv2-style)...
2026/05/19 16:54:42 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccXRayIndexingRule_serial
=== PAUSE TestAccXRayIndexingRule_serial
=== CONT  TestAccXRayIndexingRule_serial
=== RUN   TestAccXRayIndexingRule_serial/basic
=== RUN   TestAccXRayIndexingRule_serial/Identity
=== RUN   TestAccXRayIndexingRule_serial/Identity/basic
=== RUN   TestAccXRayIndexingRule_serial/Identity/RegionOverride
--- PASS: TestAccXRayIndexingRule_serial (62.91s)
    --- PASS: TestAccXRayIndexingRule_serial/basic (14.99s)
    --- PASS: TestAccXRayIndexingRule_serial/Identity (47.93s)
        --- PASS: TestAccXRayIndexingRule_serial/Identity/basic (25.62s)
        --- PASS: TestAccXRayIndexingRule_serial/Identity/RegionOverride (22.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/xray	77.776s

@ewbankkit ewbankkit merged commit dcc3a20 into main May 20, 2026
74 checks passed
@ewbankkit ewbankkit deleted the f-r/aws_xray_indexing_rule branch May 20, 2026 13:46
@github-actions
Copy link
Copy Markdown
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions
Copy link
Copy Markdown
Contributor

This functionality has been released in v6.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions Bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/xray Issues and PRs that pertain to the xray service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[New Resource]: CloudWatch X-Ray Transaction Search (aka Indexing Rule)

2 participants