Skip to content

Use ExpectResourceAction with _disappears tests (d*-e* services)#47989

Merged
jar-b merged 39 commits into
mainfrom
td-disappears-d
May 20, 2026
Merged

Use ExpectResourceAction with _disappears tests (d*-e* services)#47989
jar-b merged 39 commits into
mainfrom
td-disappears-d

Conversation

@jar-b
Copy link
Copy Markdown
Member

@jar-b jar-b commented May 20, 2026

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds ExpectResourceAction config plan checks to assert that the intended resource is planned for re-creation. Covers all services starting with b and c.

AI Disclosure: An AI agent was used to apply these changes. All code has been reviewed by a human and I fully understand the scope of changes made.

Relations

Relates #42261
Relates #47914
Relates #47960
Relates #47968

jar-b added 30 commits May 20, 2026 14:22
@jar-b
.ci/semgrep: add internal/service/[d|e]* to _disappears check inc…
60e9502 
…lude path
@jar-b
r/aws_s3_bucket(test): semgrep ignore `disappears-expect-resource-act…
706a530 
…ion` false positive
@jar-b
r/aws_sqs_queue(test): semgrep ignore `disappears-expect-resource-act…
ee99817 
…ion` false positive
@jar-b
r/aws_route53resolver_dnssec_config(test): fix _disappears test naming
5fb6fe0
@jar-b
dataexchange: use ExpectResourceAction with _disappears tests
89c3f8f
@jar-b
datapipeline: use ExpectResourceAction with _disappears tests
5ac3df2
@jar-b
datasync: use ExpectResourceAction with _disappears tests
ac13955
@jar-b
datazone: use ExpectResourceAction with _disappears tests
8f2228a
@jar-b
dax: use ExpectResourceAction with _disappears tests
84d526f
@jar-b
deploy: use ExpectResourceAction with _disappears tests
7014fd8
@jar-b
detective: use ExpectResourceAction with _disappears tests
546f350
@jar-b
devicefarm: use ExpectResourceAction with _disappears tests
6e51ab0
@jar-b
devopsguru: use ExpectResourceAction with _disappears tests
346e0cf
@jar-b
directconnect: use ExpectResourceAction with _disappears tests
a499e69
@jar-b
dlm: use ExpectResourceAction with _disappears tests
3afd72d
@jar-b
dms: use ExpectResourceAction with _disappears tests
d565d21
@jar-b
docdb: use ExpectResourceAction with _disappears tests
c95a6b0
@jar-b
docdbelastic: use ExpectResourceAction with _disappears tests
5e440bd
@jar-b
drs: use ExpectResourceAction with _disappears tests
28b5d34
@jar-b
ds: use ExpectResourceAction with _disappears tests
128a2b5
@jar-b
dsql: use ExpectResourceAction with _disappears tests
38cfc1b
@jar-b
dynamodb: use ExpectResourceAction with _disappears tests
89a129c
@jar-b
ec2: use ExpectResourceAction with _disappears tests
7fe426b
@jar-b
ecr: use ExpectResourceAction with _disappears tests
fc7015e
@jar-b
ecrpublic: use ExpectResourceAction with _disappears tests
8bd2562
@jar-b
ecs: use ExpectResourceAction with _disappears tests
c8697fb
@jar-b
efs: use ExpectResourceAction with _disappears tests
47d3bd8
@jar-b
eks: use ExpectResourceAction with _disappears tests
0f96f4b
@jar-b
elasticache: use ExpectResourceAction with _disappears tests
070e854
@jar-b
elasticbeanstalk: use ExpectResourceAction with _disappears tests
80d38cf
@github-actions github-actions Bot added service/events Issues and PRs that pertain to the events service. service/elastictranscoder Issues and PRs that pertain to the elastictranscoder service. service/ds Issues and PRs that pertain to the ds service. service/devopsguru Issues and PRs that pertain to the devopsguru service. service/vpnclient Issues and PRs that pertain to the vpnclient service. service/deploy Issues and PRs that pertain to the deploy service. service/transitgateway Issues and PRs that pertain to the transitgateway service. service/wavelength Issues and PRs that pertain to the wavelength service. service/drs Issues and PRs that pertain to the drs service. service/dms Issues and PRs that pertain to the dms service. service/ec2outposts Issues and PRs that pertain to the ec2outposts service. service/vpc Issues and PRs that pertain to the vpc service. service/evidently Issues and PRs that pertain to the evidently service. service/vpnsite Issues and PRs that pertain to the vpnsite service. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. service/emrserverless Issues and PRs that pertain to the emrserverless service. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. service/datazone Issues and PRs that pertain to the datazone service. service/dsql Issues and PRs that pertain to the dsql service. size/XL Managed by automation to categorize the size of a PR. labels May 20, 2026
@jar-b jar-b marked this pull request as ready for review May 20, 2026 18:49
@jar-b jar-b requested a review from a team as a code owner May 20, 2026 18:49
YakDriver
YakDriver approved these changes May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 🎉

@jar-b jar-b merged commit 5642185 into main May 20, 2026
67 checks passed
@jar-b jar-b deleted the td-disappears-d branch May 20, 2026 20:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions Bot added this to the v6.47.0 milestone May 20, 2026
This was referenced May 21, 2026
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

No one assigned

Labels

linter Pertains to changes to or issues with the various linters. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/dataexchange Issues and PRs that pertain to the dataexchange service. service/datapipeline Issues and PRs that pertain to the datapipeline service. service/datasync Issues and PRs that pertain to the datasync service. service/datazone Issues and PRs that pertain to the datazone service. service/dax Issues and PRs that pertain to the dax service. service/deploy Issues and PRs that pertain to the deploy service. service/detective Issues and PRs that pertain to the detective service. service/devicefarm Issues and PRs that pertain to the devicefarm service. service/devopsguru Issues and PRs that pertain to the devopsguru service. service/directconnect Issues and PRs that pertain to the directconnect service. service/dlm Issues and PRs that pertain to the dlm service. service/dms Issues and PRs that pertain to the dms service. service/docdb Issues and PRs that pertain to the docdb service. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. service/drs Issues and PRs that pertain to the drs service. service/ds Issues and PRs that pertain to the ds service. service/dsql Issues and PRs that pertain to the dsql service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. service/ec2outposts Issues and PRs that pertain to the ec2outposts service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecr Issues and PRs that pertain to the ecr service. service/ecrpublic Issues and PRs that pertain to the ecrpublic service. service/ecs Issues and PRs that pertain to the ecs service. service/efs Issues and PRs that pertain to the efs service. service/eks Issues and PRs that pertain to the eks service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/elastictranscoder Issues and PRs that pertain to the elastictranscoder service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/emr Issues and PRs that pertain to the emr service. service/emrcontainers Issues and PRs that pertain to the emrcontainers service. service/emrserverless Issues and PRs that pertain to the emrserverless service. service/events Issues and PRs that pertain to the events service. service/evidently Issues and PRs that pertain to the evidently service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/s3 Issues and PRs that pertain to the s3 service. service/sqs Issues and PRs that pertain to the sqs service. service/transitgateway Issues and PRs that pertain to the transitgateway service. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. service/vpc Issues and PRs that pertain to the vpc service. service/vpnclient Issues and PRs that pertain to the vpnclient service. service/vpnsite Issues and PRs that pertain to the vpnsite service. service/wavelength Issues and PRs that pertain to the wavelength service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v6.47.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jar-b @YakDriver