Skip to content

r/aws_codebuild_fleet: Allow base_capacity of 0 🤖🤖🤖 - #49912

Open
Samuel-Harris wants to merge 2 commits into
hashicorp:mainfrom
Samuel-Harris:b-aws_codebuild_fleet-base-capacity-zero
Open

r/aws_codebuild_fleet: Allow base_capacity of 0 🤖🤖🤖#49912
Samuel-Harris wants to merge 2 commits into
hashicorp:mainfrom
Samuel-Harris:b-aws_codebuild_fleet-base-capacity-zero

Conversation

@Samuel-Harris

Copy link
Copy Markdown

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

No.

Description

aws_codebuild_fleet rejected base_capacity = 0 in schema validation (validation.IntAtLeast(1)) even though AWS CloudFormation documents BaseCapacity with a minimum of 0. That blocked Terraform-managing a reserved fleet with no warm hosts.

This PR changes the validator to IntAtLeast(0), documents the minimum, and extends TestAccCodeBuildFleet_baseCapacity to create with 0 then update to 1.

AI usage: An LLM agent drafted the issue, schema/test/docs change, and this PR. I reviewed the diff and own the submission.

Relations

Closes #49911

References

Output from Acceptance Testing

Acceptance tests were not run locally (no Go toolchain on this machine; also creates a real CodeBuild reserved fleet). Please run:

% make testacc TESTS=TestAccCodeBuildFleet_baseCapacity PKG=codebuild

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/codebuild Issues and PRs that pertain to the codebuild service. labels Sep 9, 2026
@Samuel-Harris
Samuel-Harris marked this pull request as ready for review September 9, 2026 13:16
@Samuel-Harris
Samuel-Harris requested a review from a team as a code owner September 9, 2026 13:16
@github-actions github-actions Bot added the size/XS Managed by automation to categorize the size of a PR. label Sep 9, 2026
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/codebuild Issues and PRs that pertain to the codebuild service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: aws_codebuild_fleet rejects base_capacity = 0, but AWS allows 0

2 participants